From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Starikovskiy Subject: Re: [PATCH 11/37] drivers/acpi: Use kmemdup Date: Sun, 16 May 2010 01:33:28 +0400 Message-ID: <4BEF1328.8040306@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Julia Lawall Cc: Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Hi Julia, Acked-by: Alexey Starikovskiy Thanks, Alex. 16.05.2010 01:16, Julia Lawall =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > From: Julia Lawall > > Use kmemdup when some other buffer is immediately copied into the > allocated region. > > A simplified version of the semantic patch that makes this change is = as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression from,to,size,flag; > statement S; > @@ > > - to =3D \(kmalloc\|kzalloc\)(size,flag); > + to =3D kmemdup(from,size,flag); > if (to=3D=3DNULL || ...) S > - memcpy(to, from, size); > // > > Signed-off-by: Julia Lawall > > --- > drivers/acpi/ec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -u -p a/drivers/acpi/ec.c b/drivers/acpi/ec.c > --- a/drivers/acpi/ec.c > +++ b/drivers/acpi/ec.c > @@ -1027,10 +1027,9 @@ int __init acpi_ec_ecdt_probe(void) > /* Don't trust ECDT, which comes from ASUSTek */ > if (!EC_FLAGS_VALIDATE_ECDT) > goto install; > - saved_ec =3D kmalloc(sizeof(struct acpi_ec), GFP_KERNEL); > + saved_ec =3D kmemdup(boot_ec, sizeof(struct acpi_ec), GFP_KERNEL); > if (!saved_ec) > return -ENOMEM; > - memcpy(saved_ec, boot_ec, sizeof(struct acpi_ec)); > /* fall through */ > } >