From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Len Brown <lenb@kernel.org>,
"Moore, Robert" <robert.moore@intel.com>,
linux-acpi <linux-acpi@vger.kernel.org>
Subject: Re: ACPICA Release 20100528 linuxized patches
Date: Wed, 02 Jun 2010 14:06:45 +0400 [thread overview]
Message-ID: <4C062D35.3010900@suse.de> (raw)
In-Reply-To: <1275444837.3431.11.camel@minggr.sh.intel.com>
Hi Ming,
02.06.2010 06:13, Lin Ming пишет:
> diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c
> index 38293fd..00a444f 100644
> --- a/drivers/acpi/acpica/exfldio.c
> +++ b/drivers/acpi/acpica/exfldio.c
> @@ -698,15 +698,7 @@ acpi_ex_extract_from_field(union acpi_operand_object *obj_desc,
> ACPI_MEMSET(buffer, 0, buffer_length);
> access_bit_width = ACPI_MUL_8(obj_desc->common_field.access_byte_width);
>
> - /* Handle the simple case here */
> -
> - if ((obj_desc->common_field.start_field_bit_offset == 0) &&
> - (obj_desc->common_field.bit_length == access_bit_width)) {
I would guess we need to zero the whole buffer here... Buffer length is sizeof(ACPI_INTEGER), we read only 8 bits,
everything else is packed with garbage.
> - status = acpi_ex_field_datum_io(obj_desc, 0, buffer, ACPI_READ);
> - return_ACPI_STATUS(status);
> - }
> -
Thanks,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-02 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 9:07 ACPICA Release 20100528 linuxized patches Lin Ming
2010-06-02 2:13 ` Lin Ming
2010-06-02 9:37 ` Alexey Starikovskiy
2010-06-02 10:06 ` Alexey Starikovskiy [this message]
2010-06-04 17:46 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C062D35.3010900@suse.de \
--to=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).