Re: [PATCH -v6 2/2] IPMI: use ACPI detection mechanism firstly to detect IPMI system interface

[Corey Minyard <minyard@acm.org>]

ykzhao wrote:
> My first thought is to put the ACPI-IPMI opregion handler into ACPI
> subsystem. But Bjorn suggests that it can be put into the smi code. Then
> I follow his suggestion.
>
> OK. I will rewrite the code and don't tie the ACPI-IPMI opregion handler
> to the smi code.
>   
I think it's ok to be in the ipmi directory, just not directly with the 
SMI code.  I'd put it in its own file, I think.

>     
>   
>> Can you look and see if there is some other way to detect the ACPI 
>> function on a BMC with some other mechanism?  I think that would be 
>> better all around.  If it's the same BMC, the I can't imagine it matters 
>> if you send the messages via the PCI-detected or ACPI-detected mechanisms.
>>     
>
> OK. I will think about it again and try to figure out one solution that
> identify the same BMC via PCI-detected or ACPI-detected and avoids
> adjusting the discovery order. 
>   
Thanks.  If there's some unique message for this function that 
idempotent, you can simply send that message and see if you get an error 
response or not.  This is used for detection ATCA function in some 
cases, for instance.

-corey

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo