linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Iain <selsinork@gmail.com>
To: Len Brown <lenb@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	"Yu, Luming" <luming.yu@intel.com>,
	Philip Langdale <philipl@overt.org>,
	Jeff Garrett <jeff@jgarrett.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"venki@google.com" <venki@google.com>
Subject: Re: [PATCH] ACPI: make acpi_idle Nehalem-aware
Date: Fri, 23 Jul 2010 13:40:50 +0100	[thread overview]
Message-ID: <4C498DD2.1040002@gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1007221751550.13016@localhost.localdomain>

Len Brown wrote:
> You read it correctly, your BIOS does not request BM_STS, mjg59's does.

Right, and on a DL360 G6 with the 07-24-2009 bios version I saw the same.

> I expect that is to enable PCC, which would change P-states,
> but unlikely would have an effect on C-states.

I found another option in the bios to limit or disable the C-states today, so plenty of opportunity to configure the system into an 
odd state.

> If you can try it both ways that might be good to know.
> (include powertop display once again)
> Of course, the default setting is what 99% of customers use...

I'll upload an archive to the bugzilla entry with the details. What seems to happen is that when you set the default Balanced Power 
and Performance mode the CST code vanishes completely and the processor manages to get to c6 some of the time. Enable OS Control 
mode and the bad CST code appears.

> This is BIOS writer "value add".
> Unclear how it migh be an improvement over what Linux has been shipping 
> for years.

Well yes, having Linux and the bios fighting for control probably isn't going to help.

> Please upload the output from dmidecode to the bug report.
> I am hopeful that you have a current BIOS and that
> Matthew may have an pre-production BIOS.

I've uploaded an archive with dmidecode, turbostat and powertop dumps. There are dumps with the bios set to the default, and to OS 
Control mode.
The original bios on my DL360G6 was 07-24-2009 and has the same issue as Matthew. I upgraded the machine to the latest 2010.05.15 
and repeated the tests.
Good news is that the new bios has fixed the CST code so that the Access length values are all 0x01 when they're present and the 
dumps show the processor getting into c6 much more.

So you were correct, bios fix was needed.

Iain

  reply	other threads:[~2010-07-23 12:40 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26  8:47 acpi_idle: Very idle Core i7 machine never enters C3 Jeff Garrett
2010-01-26 12:41 ` peng huang
2010-01-26 14:59   ` Jeff Garrett
2010-01-27 13:27     ` peng huang
2010-02-05 16:22       ` Jeff Garrett
2010-01-26 21:45 ` Andi Kleen
2010-02-05 16:09   ` Jeff Garrett
2010-02-05 17:45     ` Len Brown
2010-02-05 20:53       ` Jeff Garrett
2010-04-27  2:40       ` Philip Langdale
2010-04-27  7:26         ` Len Brown
2010-04-27 15:41           ` Philip Langdale
2010-04-27 12:47         ` Jeff Garrett
2010-04-30 14:57           ` Philip Langdale
2010-04-30 16:25           ` Len Brown
2010-04-30 17:44             ` Matthew Garrett
2010-04-30 18:35               ` Philip Langdale
2010-05-25  5:43                 ` Len Brown
2010-05-25  5:59                   ` Yu, Luming
2010-05-25 12:39                     ` Matthew Garrett
2010-05-25 12:43                     ` Matthew Garrett
2010-05-25 15:33                       ` Len Brown
2010-05-25 18:55                         ` Matthew Garrett
2010-07-21 21:31                           ` [PATCH] ACPI: make acpi_idle Nehalem-aware Len Brown
2010-07-22  0:53                             ` Venkatesh Pallipadi
2010-07-22  7:47                             ` Andi Kleen
2010-07-22 15:57                               ` Len Brown
2010-07-22 21:21                                 ` [PATCH] ACPI: skip checking BM_STS if the BIOS doesn't ask for it Len Brown
2010-07-22 21:40                                   ` [PATCH] ACPI: create "processor.bm_check_disable" boot param Len Brown
2010-07-26  7:24                                     ` Andi Kleen
2010-07-27  0:19                                       ` Len Brown
2010-07-27 11:28                                         ` Andi Kleen
2010-07-28 18:58                                           ` Len Brown
2010-07-22 21:25                                 ` [PATCH] ACPI: make acpi_idle Nehalem-aware Iain
2010-07-22 21:53                                   ` Iain
2010-07-22 22:01                                   ` Len Brown
2010-07-23 12:40                                     ` Iain [this message]
2010-08-03  6:55                             ` Pavel Machek
2010-08-03  7:05                               ` Andi Kleen
2010-05-25 12:37                   ` acpi_idle: Very idle Core i7 machine never enters C3 Matthew Garrett
2010-05-25 15:40                     ` Len Brown
2010-07-22  5:34           ` Len Brown
2010-02-01 14:10 ` Pavel Machek
2010-02-05 16:30   ` Jeff Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C498DD2.1040002@gmail.com \
    --to=selsinork@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=jeff@jgarrett.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luming.yu@intel.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=philipl@overt.org \
    --cc=venki@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).