linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Alok Kataria <akataria@vmware.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Petr Vandrovec <petr@vmware.com>
Subject: Re: swiotlb detection should be memory hotplug aware ?
Date: Fri, 23 Jul 2010 17:23:33 +0200	[thread overview]
Message-ID: <4C49B3F5.3030904@linux.intel.com> (raw)
In-Reply-To: <20100723145945.GA31857@phenom.dumpdata.com>


> I was thinking about this at some point. I think the first step is to
> make SWIOTLB use the debugfs to actually print out how much of its
> buffers are used - and see if the 64MB is a good fit.

swiotlb is near always wrongly sized. For most system it's far too much, 
but for some
not enough. I have some systemtap scripts around to instrument it.

Also it depends on the IO load, so if you size it reasonable you
risk overflow on large IO (however these days this very rarely happens 
because
all "serious" IO devices don't need swiotlb anymore)

The other problem is that using only  two bits for the needed address 
space is also extremly
inefficient (4GB and 16MB on x86). Really want masks everywhere and 
optimize for the
actual requirements.

> The shrinking part scares me - I think it might be more prudent to first
> explore on how to grow it. The big problem looks to allocate a physical
> contiguity set of pages. And I guess SWIOTLB would need to change from
> using one big region to something of a pool system?
>

Shrinking: you define a movable zone, so with some delay it can be 
always freed.

The problem with swiotlb is however it still cannot block, but it can 
adapt to load.

The real fix would be blockable swiotlb, but the way drivers are set up 
this is difficult
(at least in kernels using spinlocks)

>> allocator patchkit,
>> unfortunately that didn't go forward.
> I wasn't present at that time so I don't know what the issues were - you
> wouldn't have a link to LKML for this?


There wasn't all that much opposition, but I ran out of time because 
fixing the infrastructure
(e.g. getting rid of all of GFP_DMA) is a lot of work. In a sense it's a 
big tree sweep project like
getting rid of BKL.

The old patch kit is at ftp://firstfloor.org/pub/ak/dma/
"intro" has the rationale.

I have a slightly newer version of the SCSI & misc drivers patchkit 
somewhere.

-Andi


  reply	other threads:[~2010-07-23 15:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-13  2:07 swiotlb detection should be memory hotplug aware ? Alok Kataria
2010-03-13  3:09 ` Andi Kleen
2010-03-15 17:22   ` Alok Kataria
2010-03-16  0:51   ` [LKML] " Konrad Rzeszutek Wilk
2010-03-16  1:33     ` FUJITA Tomonori
2010-03-16 12:45       ` [LKML] " Konrad Rzeszutek Wilk
2010-03-17 22:48         ` Alok Kataria
2010-07-20 22:14           ` Alok Kataria
2010-07-21  4:58             ` FUJITA Tomonori
2010-07-21 17:13               ` Alok Kataria
2010-07-21 23:44                 ` FUJITA Tomonori
2010-07-22  0:03                   ` FUJITA Tomonori
2010-07-22 18:34                     ` Alok Kataria
2010-07-23 14:22                       ` Konrad Rzeszutek Wilk
2010-07-23 14:33                         ` Andi Kleen
2010-07-23 14:59                           ` Konrad Rzeszutek Wilk
2010-07-23 15:23                             ` Andi Kleen [this message]
2010-07-28 10:10                               ` FUJITA Tomonori
2010-07-28 11:09                                 ` Andi Kleen
2010-07-28 14:20                                   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C49B3F5.3030904@linux.intel.com \
    --to=ak@linux.intel.com \
    --cc=akataria@vmware.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=konrad.wilk@oracle.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petr@vmware.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).