From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
linux-pm@lists.linux-foundation.org, linux-pci@vger.kernel.org,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 1/8] ACPI / PCI: Introduce acpi_pci_osc_control_query()
Date: Tue, 03 Aug 2010 14:04:06 +0900 [thread overview]
Message-ID: <4C57A346.6020003@jp.fujitsu.com> (raw)
In-Reply-To: <201008022353.04353.rjw@sisk.pl>
(2010/08/03 6:53), Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki<rjw@sisk.pl>
<snip.>
> + mutex_lock(&osc_lock);
> + status = acpi_pci_query_osc(root, root->osc_support_set, ctrl_mask);
> + mutex_unlock(&osc_lock);
> +
One more comment here.
I think we can skip acpi_pci_query_osc() if all of queried controls are
already granted to OS. Please see below
mutex_lock(&osc_lock);
if ((root->osc_control_set & *ctrl_mask) == *ctrl_mask) {
*ctrl_mask = root->osc_control_set;
goto out;
}
status = acpi_pci_query_osc(root, root->osc_support_set, ctrl_mask);
mutex_unlock(&osc_lock);
out:
Thanks,
Kenji Kaneshige
next prev parent reply other threads:[~2010-08-03 5:04 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 21:51 [PATCH 0/8] ACPI / PCI / PCIe: Rework _OSC handling (v2) Rafael J. Wysocki
2010-08-02 21:53 ` [PATCH 1/8] ACPI / PCI: Introduce acpi_pci_osc_control_query() Rafael J. Wysocki
2010-08-03 4:52 ` Kenji Kaneshige
2010-08-03 9:24 ` Rafael J. Wysocki
2010-08-03 5:04 ` Kenji Kaneshige [this message]
2010-08-03 9:27 ` Rafael J. Wysocki
2010-08-03 20:58 ` [linux-pm] " Rafael J. Wysocki
2010-08-04 4:28 ` Kenji Kaneshige
2010-08-04 23:37 ` Rafael J. Wysocki
2010-08-05 23:46 ` Rafael J. Wysocki
2010-08-02 21:54 ` [PATCH 2/8] PCI / PCIe/ AER: Introduce pci_aer_available() Rafael J. Wysocki
2010-08-03 0:46 ` Hidetoshi Seto
2010-08-03 9:28 ` Rafael J. Wysocki
2010-08-03 20:59 ` [linux-pm] " Rafael J. Wysocki
2010-08-03 9:41 ` Jike Song
2010-08-03 19:50 ` Rafael J. Wysocki
2010-08-02 21:55 ` [PATCH 3/8] PCI / PCIe: Introduce commad line switch for disabling port services Rafael J. Wysocki
2010-08-02 21:56 ` [PATCH 4/8] PCI / PCIe: Ask BIOS for control of all native services at once (v6) Rafael J. Wysocki
2010-08-03 1:14 ` Hidetoshi Seto
2010-08-03 21:01 ` Rafael J. Wysocki
2010-08-06 1:33 ` Hidetoshi Seto
2010-08-06 10:47 ` Rafael J. Wysocki
2010-08-02 21:57 ` [PATCH 5/8] PCI / PCIe: Disable PCIe port services during port initialization Rafael J. Wysocki
2010-08-02 21:58 ` [PATCH 6/8] PCI / PCIe: Remove the port driver module exit routine Rafael J. Wysocki
2010-08-02 21:59 ` [PATCH 7/8] ACPI / PCI: Do not preserve _OSC control bits returned by a query (v2) Rafael J. Wysocki
2010-08-03 4:52 ` Kenji Kaneshige
2010-08-03 7:13 ` Hidetoshi Seto
2010-08-03 9:33 ` Rafael J. Wysocki
2010-08-03 21:02 ` [linux-pm] " Rafael J. Wysocki
2010-08-04 5:46 ` Kenji Kaneshige
2010-08-04 8:41 ` Hidetoshi Seto
2010-08-04 9:23 ` Kenji Kaneshige
2010-08-04 10:29 ` Rafael J. Wysocki
2010-08-04 23:51 ` Rafael J. Wysocki
2010-08-05 3:40 ` Hidetoshi Seto
2010-08-05 14:25 ` Rafael J. Wysocki
2010-08-06 1:28 ` Hidetoshi Seto
2010-08-04 8:43 ` Hidetoshi Seto
2010-08-04 9:39 ` Kenji Kaneshige
2010-08-04 12:15 ` Rafael J. Wysocki
2010-08-05 3:38 ` [linux-pm] " Hidetoshi Seto
2010-08-04 10:38 ` Rafael J. Wysocki
2010-08-02 22:00 ` [PATCH 8/8] ACPI / PCI: Reorder checks in acpi_pci_osc_control_set() Rafael J. Wysocki
2010-08-03 4:51 ` [PATCH 0/8] ACPI / PCI / PCIe: Rework _OSC handling (v2) Kenji Kaneshige
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C57A346.6020003@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).