* [PATCH] ACPI: acpi_pad: fix uninitialized variable warning
@ 2010-08-03 19:17 Bill Pemberton
2010-08-04 3:46 ` Chen Gong
0 siblings, 1 reply; 2+ messages in thread
From: Bill Pemberton @ 2010-08-03 19:17 UTC (permalink / raw)
To: trivial; +Cc: linux-acpi
drivers/acpi/acpi_pad.c:432: warning: 'num_cpus' may be used
uninitialized in this function
num_cpus is set by the call to acpi_pad_pur()
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
---
drivers/acpi/acpi_pad.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
index b76848c..69e2593 100644
--- a/drivers/acpi/acpi_pad.c
+++ b/drivers/acpi/acpi_pad.c
@@ -429,7 +429,7 @@ static void acpi_pad_ost(acpi_handle handle, int stat,
static void acpi_pad_handle_notify(acpi_handle handle)
{
- int num_cpus;
+ int uninitialized_var(num_cpus);
uint32_t idle_cpus;
mutex_lock(&isolated_cpus_lock);
--
1.7.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: acpi_pad: fix uninitialized variable warning
2010-08-03 19:17 [PATCH] ACPI: acpi_pad: fix uninitialized variable warning Bill Pemberton
@ 2010-08-04 3:46 ` Chen Gong
0 siblings, 0 replies; 2+ messages in thread
From: Chen Gong @ 2010-08-04 3:46 UTC (permalink / raw)
To: Bill Pemberton; +Cc: trivial, linux-acpi
于 8/4/2010 3:17 AM, Bill Pemberton 写道:
> drivers/acpi/acpi_pad.c:432: warning: 'num_cpus' may be used
> uninitialized in this function
>
> num_cpus is set by the call to acpi_pad_pur()
>
> Signed-off-by: Bill Pemberton<wfp5p@virginia.edu>
> ---
> drivers/acpi/acpi_pad.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpi_pad.c b/drivers/acpi/acpi_pad.c
> index b76848c..69e2593 100644
> --- a/drivers/acpi/acpi_pad.c
> +++ b/drivers/acpi/acpi_pad.c
> @@ -429,7 +429,7 @@ static void acpi_pad_ost(acpi_handle handle, int stat,
>
> static void acpi_pad_handle_notify(acpi_handle handle)
> {
> - int num_cpus;
> + int uninitialized_var(num_cpus);
> uint32_t idle_cpus;
>
> mutex_lock(&isolated_cpus_lock);
It is not necessary because the 1st usage of this variable is as
left-value, not right-value.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-04 3:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-03 19:17 [PATCH] ACPI: acpi_pad: fix uninitialized variable warning Bill Pemberton
2010-08-04 3:46 ` Chen Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).