From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jin Dongming Subject: Re: [PATCH 1/4] [Patch-next] ACPI, APEI, ERST Fix the wrong checking of Serialization Header's length Date: Tue, 17 Aug 2010 13:44:13 +0900 Message-ID: <4C6A139D.20507@np.css.fujitsu.com> References: <4C69DDB5.6060103@np.css.fujitsu.com> <1282008836.2744.1490.camel@yhuang-dev> <4C69F094.1040607@np.css.fujitsu.com> <1282015344.2744.1500.camel@yhuang-dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:50743 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799Ab0HQEob (ORCPT ); Tue, 17 Aug 2010 00:44:31 -0400 In-Reply-To: <1282015344.2744.1500.camel@yhuang-dev> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Huang Ying Cc: Randy Dunlap , Stephen Rothwell , Andi Kleen , Hidetoshi Seto , ACPI , LKLM , Lu Yinghai (2010/08/17 12:22), Huang Ying wrote: > On Tue, 2010-08-17 at 10:14 +0800, Jin Dongming wrote: >>> I don't think it is necessary to change the header definition, and >>> seri_header is not a good name for me. >> Why I added this structure here is that I don't want to do following checking. >> For example, >> if (header_length != 0x0c) { >> ... >> } > > This can be: > > static int erst_check_table(struct acpi_table_erst *erst_tab) > { > - if (erst_tab->header_length != sizeof(struct acpi_table_erst)) > + if (erst_tab->header_length != > + (sizeof(struct acpi_table_erst) - sizeof(erst_tab->header))) > > like Yinghai has been done. > Yes. It looks good. And I am sorry I am unaware of Yinghai' patch. > Best Regards, > Huang Ying > > Best Regards, Jin Dongming > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > >