* [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence
@ 2010-09-19 22:02 Rafael J. Wysocki
2010-09-20 6:18 ` Chen Gong
0 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2010-09-19 22:02 UTC (permalink / raw)
To: Jesse Barnes
Cc: LKML, linux-pci, Huang Ying, Hidetoshi Seto, Kenji Kaneshige,
Matthew Garrett, ACPI Devel Maling List
From: Rafael J. Wysocki <rjw@sisk.pl>
There is a design issue related to PCIe AER and _OSC that the BIOS
may be asked to grant control of the AER service even if some
Hardware Error Source Table (HEST) entries contain information
meaning that the BIOS really should control it. Namely,
pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that
determines whether or not the AER service should be controlled by
the BIOS on the basis of the HEST information for the given PCIe
port. The BIOS is asked to grant control of the AER service for
a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false'
for at least one root port in that complex, even if all of the other
root ports' HEST entries have the FIRMWARE_FIRST flag set (and none
of them has the GLOBAL flag set). However, if the AER service is
controlled by the kernel, that may interfere with the BIOS' handling
of the error sources having the FIRMWARE_FIRST flag. Moreover,
there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in
HEST and are attached to the root ports in question, in which case it
also may be unsafe to ask the BIOS for control of the AER service.
For this reason, introduce a function checking if there's at least
one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and
disable the native AER service altogether if this function returns
'true'.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/pci/pcie/aer/aerdrv.c | 2 +-
drivers/pci/pcie/aer/aerdrv.h | 3 +++
drivers/pci/pcie/aer/aerdrv_acpi.c | 31 +++++++++++++++++++++++++++++++
drivers/pci/pcie/portdrv_acpi.c | 2 +-
4 files changed, 36 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv_acpi.c
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
@@ -93,4 +93,35 @@ int pcie_aer_get_firmware_first(struct p
aer_set_firmware_first(dev);
return dev->__aer_firmware_first;
}
+
+static bool aer_firmware_first;
+
+static int aer_hest_parse_aff(struct acpi_hest_header *hest_hdr, void *data)
+{
+ if (aer_firmware_first)
+ return 0;
+
+ switch (hest_hdr->type) {
+ case ACPI_HEST_TYPE_AER_ROOT_PORT:
+ case ACPI_HEST_TYPE_AER_ENDPOINT:
+ case ACPI_HEST_TYPE_AER_BRIDGE:
+ aer_firmware_first = !!(p->flags & ACPI_HEST_FIRMWARE_FIRST);
+ default:
+ return 0;
+ }
+}
+
+/**
+ * aer_acpi_firmware_first - Check if APEI should control AER.
+ */
+bool aer_acpi_firmware_first(void)
+{
+ static bool parsed = false;
+
+ if (!parsed) {
+ apei_hest_parse(aer_hest_parse_aff, NULL);
+ parsed = true;
+ }
+ return aer_firmware_first;
+}
#endif
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.h
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.h
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv.h
@@ -132,6 +132,7 @@ static inline int aer_osc_setup(struct p
#ifdef CONFIG_ACPI_APEI
extern int pcie_aer_get_firmware_first(struct pci_dev *pci_dev);
+extern bool aer_acpi_firmware_first(void);
#else
static inline int pcie_aer_get_firmware_first(struct pci_dev *pci_dev)
{
@@ -139,6 +140,8 @@ static inline int pcie_aer_get_firmware_
return pci_dev->__aer_firmware_first;
return 0;
}
+
+static inline bool aer_acpi_firmware_first(void) { return false; }
#endif
static inline void pcie_aer_force_firmware_first(struct pci_dev *pci_dev,
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.c
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv.c
@@ -416,7 +416,7 @@ static void aer_error_resume(struct pci_
*/
static int __init aer_service_init(void)
{
- if (!pci_aer_available())
+ if (!pci_aer_available() || aer_acpi_firmware_first())
return -ENXIO;
return pcie_port_service_register(&aerdriver);
}
Index: linux-2.6/drivers/pci/pcie/portdrv_acpi.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
+++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
@@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
| OSC_PCI_EXPRESS_PME_CONTROL;
if (pci_aer_available()) {
- if (pcie_aer_get_firmware_first(port))
+ if (aer_acpi_firmware_first())
dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
else
flags |= OSC_PCI_EXPRESS_AER_CONTROL;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence
2010-09-19 22:02 [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence Rafael J. Wysocki
@ 2010-09-20 6:18 ` Chen Gong
2010-09-20 16:50 ` [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...) Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Chen Gong @ 2010-09-20 6:18 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Jesse Barnes, LKML, linux-pci, Huang Ying, Hidetoshi Seto,
Kenji Kaneshige, Matthew Garrett, ACPI Devel Maling List
于 9/20/2010 6:02 AM, Rafael J. Wysocki 写道:
> From: Rafael J. Wysocki<rjw@sisk.pl>
>
> There is a design issue related to PCIe AER and _OSC that the BIOS
> may be asked to grant control of the AER service even if some
> Hardware Error Source Table (HEST) entries contain information
> meaning that the BIOS really should control it. Namely,
> pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that
> determines whether or not the AER service should be controlled by
> the BIOS on the basis of the HEST information for the given PCIe
> port. The BIOS is asked to grant control of the AER service for
> a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false'
> for at least one root port in that complex, even if all of the other
> root ports' HEST entries have the FIRMWARE_FIRST flag set (and none
> of them has the GLOBAL flag set). However, if the AER service is
> controlled by the kernel, that may interfere with the BIOS' handling
> of the error sources having the FIRMWARE_FIRST flag. Moreover,
> there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in
> HEST and are attached to the root ports in question, in which case it
> also may be unsafe to ask the BIOS for control of the AER service.
>
> For this reason, introduce a function checking if there's at least
> one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and
> disable the native AER service altogether if this function returns
> 'true'.
>
> Signed-off-by: Rafael J. Wysocki<rjw@sisk.pl>
> ---
> drivers/pci/pcie/aer/aerdrv.c | 2 +-
> drivers/pci/pcie/aer/aerdrv.h | 3 +++
> drivers/pci/pcie/aer/aerdrv_acpi.c | 31 +++++++++++++++++++++++++++++++
> drivers/pci/pcie/portdrv_acpi.c | 2 +-
> 4 files changed, 36 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv_acpi.c
> +++ linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
> @@ -93,4 +93,35 @@ int pcie_aer_get_firmware_first(struct p
> aer_set_firmware_first(dev);
> return dev->__aer_firmware_first;
> }
> +
> +static bool aer_firmware_first;
> +
> +static int aer_hest_parse_aff(struct acpi_hest_header *hest_hdr, void *data)
> +{
> + if (aer_firmware_first)
> + return 0;
> +
> + switch (hest_hdr->type) {
> + case ACPI_HEST_TYPE_AER_ROOT_PORT:
> + case ACPI_HEST_TYPE_AER_ENDPOINT:
> + case ACPI_HEST_TYPE_AER_BRIDGE:
> + aer_firmware_first = !!(p->flags& ACPI_HEST_FIRMWARE_FIRST);
Where "p" comes from ? Maybe it points to "struct acpi_hest_aer_common *p;"
> + default:
> + return 0;
> + }
> +}
> +
> +/**
> + * aer_acpi_firmware_first - Check if APEI should control AER.
> + */
> +bool aer_acpi_firmware_first(void)
> +{
> + static bool parsed = false;
> +
> + if (!parsed) {
> + apei_hest_parse(aer_hest_parse_aff, NULL);
> + parsed = true;
> + }
> + return aer_firmware_first;
> +}
> #endif
> Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.h
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.h
> +++ linux-2.6/drivers/pci/pcie/aer/aerdrv.h
> @@ -132,6 +132,7 @@ static inline int aer_osc_setup(struct p
>
> #ifdef CONFIG_ACPI_APEI
> extern int pcie_aer_get_firmware_first(struct pci_dev *pci_dev);
> +extern bool aer_acpi_firmware_first(void);
> #else
> static inline int pcie_aer_get_firmware_first(struct pci_dev *pci_dev)
> {
> @@ -139,6 +140,8 @@ static inline int pcie_aer_get_firmware_
> return pci_dev->__aer_firmware_first;
> return 0;
> }
> +
> +static inline bool aer_acpi_firmware_first(void) { return false; }
> #endif
>
> static inline void pcie_aer_force_firmware_first(struct pci_dev *pci_dev,
> Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.c
> +++ linux-2.6/drivers/pci/pcie/aer/aerdrv.c
> @@ -416,7 +416,7 @@ static void aer_error_resume(struct pci_
> */
> static int __init aer_service_init(void)
> {
> - if (!pci_aer_available())
> + if (!pci_aer_available() || aer_acpi_firmware_first())
> return -ENXIO;
> return pcie_port_service_register(&aerdriver);
> }
> Index: linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
> | OSC_PCI_EXPRESS_PME_CONTROL;
>
> if (pci_aer_available()) {
> - if (pcie_aer_get_firmware_first(port))
> + if (aer_acpi_firmware_first())
> dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> else
> flags |= OSC_PCI_EXPRESS_AER_CONTROL;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)
2010-09-20 6:18 ` Chen Gong
@ 2010-09-20 16:50 ` Rafael J. Wysocki
2010-09-24 16:53 ` Jesse Barnes
2010-09-25 5:51 ` Huang Ying
0 siblings, 2 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2010-09-20 16:50 UTC (permalink / raw)
To: Chen Gong
Cc: Jesse Barnes, LKML, linux-pci, Huang Ying, Hidetoshi Seto,
Kenji Kaneshige, Matthew Garrett, ACPI Devel Maling List
On Monday, September 20, 2010, Chen Gong wrote:
> 于 9/20/2010 6:02 AM, Rafael J. Wysocki 写道:
> > From: Rafael J. Wysocki<rjw@sisk.pl>
> >
> > There is a design issue related to PCIe AER and _OSC that the BIOS
> > may be asked to grant control of the AER service even if some
> > Hardware Error Source Table (HEST) entries contain information
> > meaning that the BIOS really should control it. Namely,
> > pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that
> > determines whether or not the AER service should be controlled by
> > the BIOS on the basis of the HEST information for the given PCIe
> > port. The BIOS is asked to grant control of the AER service for
> > a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false'
> > for at least one root port in that complex, even if all of the other
> > root ports' HEST entries have the FIRMWARE_FIRST flag set (and none
> > of them has the GLOBAL flag set). However, if the AER service is
> > controlled by the kernel, that may interfere with the BIOS' handling
> > of the error sources having the FIRMWARE_FIRST flag. Moreover,
> > there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in
> > HEST and are attached to the root ports in question, in which case it
> > also may be unsafe to ask the BIOS for control of the AER service.
> >
> > For this reason, introduce a function checking if there's at least
> > one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and
> > disable the native AER service altogether if this function returns
> > 'true'.
> >
> > Signed-off-by: Rafael J. Wysocki<rjw@sisk.pl>
> > ---
> > drivers/pci/pcie/aer/aerdrv.c | 2 +-
> > drivers/pci/pcie/aer/aerdrv.h | 3 +++
> > drivers/pci/pcie/aer/aerdrv_acpi.c | 31 +++++++++++++++++++++++++++++++
> > drivers/pci/pcie/portdrv_acpi.c | 2 +-
> > 4 files changed, 36 insertions(+), 2 deletions(-)
> >
> > Index: linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
> > ===================================================================
> > --- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv_acpi.c
> > +++ linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
> > @@ -93,4 +93,35 @@ int pcie_aer_get_firmware_first(struct p
> > aer_set_firmware_first(dev);
> > return dev->__aer_firmware_first;
> > }
> > +
> > +static bool aer_firmware_first;
> > +
> > +static int aer_hest_parse_aff(struct acpi_hest_header *hest_hdr, void *data)
> > +{
> > + if (aer_firmware_first)
> > + return 0;
> > +
> > + switch (hest_hdr->type) {
> > + case ACPI_HEST_TYPE_AER_ROOT_PORT:
> > + case ACPI_HEST_TYPE_AER_ENDPOINT:
> > + case ACPI_HEST_TYPE_AER_BRIDGE:
> > + aer_firmware_first = !!(p->flags& ACPI_HEST_FIRMWARE_FIRST);
>
> Where "p" comes from ? Maybe it points to "struct acpi_hest_aer_common *p;"
My bad, terribly sorry.
I must have posted a wrong version of the patch. :-(
Fixed patch is appended.
Thanks,
Rafael
---
From: Rafael J. Wysocki <rjw@sisk.pl>
Subject: PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2)
There is a design issue related to PCIe AER and _OSC that the BIOS
may be asked to grant control of the AER service even if some
Hardware Error Source Table (HEST) entries contain information
meaning that the BIOS really should control it. Namely,
pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that
determines whether or not the AER service should be controlled by
the BIOS on the basis of the HEST information for the given PCIe
port. The BIOS is asked to grant control of the AER service for
a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false'
for at least one root port in that complex, even if all of the other
root ports' HEST entries have the FIRMWARE_FIRST flag set (and none
of them has the GLOBAL flag set). However, if the AER service is
controlled by the kernel, that may interfere with the BIOS' handling
of the error sources having the FIRMWARE_FIRST flag. Moreover,
there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in
HEST and are attached to the root ports in question, in which case it
also may be unsafe to ask the BIOS for control of the AER service.
For this reason, introduce a function checking if there's at least
one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and
disable the native AER service altogether if this function returns
'true'.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
Changes since v1:
* Fix compilation problem with undefined p in aer_hest_parse_aff().
---
drivers/pci/pcie/aer/aerdrv.c | 2 +-
drivers/pci/pcie/aer/aerdrv.h | 3 +++
drivers/pci/pcie/aer/aerdrv_acpi.c | 34 ++++++++++++++++++++++++++++++++++
drivers/pci/pcie/portdrv_acpi.c | 2 +-
4 files changed, 39 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv_acpi.c
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv_acpi.c
@@ -93,4 +93,38 @@ int pcie_aer_get_firmware_first(struct p
aer_set_firmware_first(dev);
return dev->__aer_firmware_first;
}
+
+static bool aer_firmware_first;
+
+static int aer_hest_parse_aff(struct acpi_hest_header *hest_hdr, void *data)
+{
+ struct acpi_hest_aer_common *p;
+
+ if (aer_firmware_first)
+ return 0;
+
+ switch (hest_hdr->type) {
+ case ACPI_HEST_TYPE_AER_ROOT_PORT:
+ case ACPI_HEST_TYPE_AER_ENDPOINT:
+ case ACPI_HEST_TYPE_AER_BRIDGE:
+ p = (struct acpi_hest_aer_common *)(hest_hdr + 1);
+ aer_firmware_first = !!(p->flags & ACPI_HEST_FIRMWARE_FIRST);
+ default:
+ return 0;
+ }
+}
+
+/**
+ * aer_acpi_firmware_first - Check if APEI should control AER.
+ */
+bool aer_acpi_firmware_first(void)
+{
+ static bool parsed = false;
+
+ if (!parsed) {
+ apei_hest_parse(aer_hest_parse_aff, NULL);
+ parsed = true;
+ }
+ return aer_firmware_first;
+}
#endif
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.h
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.h
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv.h
@@ -132,6 +132,7 @@ static inline int aer_osc_setup(struct p
#ifdef CONFIG_ACPI_APEI
extern int pcie_aer_get_firmware_first(struct pci_dev *pci_dev);
+extern bool aer_acpi_firmware_first(void);
#else
static inline int pcie_aer_get_firmware_first(struct pci_dev *pci_dev)
{
@@ -139,6 +140,8 @@ static inline int pcie_aer_get_firmware_
return pci_dev->__aer_firmware_first;
return 0;
}
+
+static inline bool aer_acpi_firmware_first(void) { return false; }
#endif
static inline void pcie_aer_force_firmware_first(struct pci_dev *pci_dev,
Index: linux-2.6/drivers/pci/pcie/aer/aerdrv.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/aer/aerdrv.c
+++ linux-2.6/drivers/pci/pcie/aer/aerdrv.c
@@ -416,7 +416,7 @@ static void aer_error_resume(struct pci_
*/
static int __init aer_service_init(void)
{
- if (!pci_aer_available())
+ if (!pci_aer_available() || aer_acpi_firmware_first())
return -ENXIO;
return pcie_port_service_register(&aerdriver);
}
Index: linux-2.6/drivers/pci/pcie/portdrv_acpi.c
===================================================================
--- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
+++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
@@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
| OSC_PCI_EXPRESS_PME_CONTROL;
if (pci_aer_available()) {
- if (pcie_aer_get_firmware_first(port))
+ if (aer_acpi_firmware_first())
dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
else
flags |= OSC_PCI_EXPRESS_AER_CONTROL;
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)
2010-09-20 16:50 ` [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...) Rafael J. Wysocki
@ 2010-09-24 16:53 ` Jesse Barnes
2010-09-25 5:51 ` Huang Ying
1 sibling, 0 replies; 6+ messages in thread
From: Jesse Barnes @ 2010-09-24 16:53 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Chen Gong, LKML, linux-pci, Huang Ying, Hidetoshi Seto,
Kenji Kaneshige, Matthew Garrett, ACPI Devel Maling List
On Mon, 20 Sep 2010 18:50:00 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> On Monday, September 20, 2010, Chen Gong wrote:
> > 于 9/20/2010 6:02 AM, Rafael J. Wysocki 写道:
> > > From: Rafael J. Wysocki<rjw@sisk.pl>
> > >
> > > There is a design issue related to PCIe AER and _OSC that the BIOS
> > > may be asked to grant control of the AER service even if some
> > > Hardware Error Source Table (HEST) entries contain information
> > > meaning that the BIOS really should control it. Namely,
> > > pcie_port_acpi_setup() calls pcie_aer_get_firmware_first() that
> > > determines whether or not the AER service should be controlled by
> > > the BIOS on the basis of the HEST information for the given PCIe
> > > port. The BIOS is asked to grant control of the AER service for
> > > a PCIe Root Complex if pcie_aer_get_firmware_first() returns 'false'
> > > for at least one root port in that complex, even if all of the other
> > > root ports' HEST entries have the FIRMWARE_FIRST flag set (and none
> > > of them has the GLOBAL flag set). However, if the AER service is
> > > controlled by the kernel, that may interfere with the BIOS' handling
> > > of the error sources having the FIRMWARE_FIRST flag. Moreover,
> > > there may be PCIe endpoints that have the FIRMWARE_FIRST flag set in
> > > HEST and are attached to the root ports in question, in which case it
> > > also may be unsafe to ask the BIOS for control of the AER service.
> > >
> > > For this reason, introduce a function checking if there's at least
> > > one PCIe-related HEST entry with the FIRMWARE_FIRST flag set and
> > > disable the native AER service altogether if this function returns
> > > 'true'.
Applied the second patch to my linux-next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)
2010-09-20 16:50 ` [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...) Rafael J. Wysocki
2010-09-24 16:53 ` Jesse Barnes
@ 2010-09-25 5:51 ` Huang Ying
2010-09-25 20:37 ` Rafael J. Wysocki
1 sibling, 1 reply; 6+ messages in thread
From: Huang Ying @ 2010-09-25 5:51 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Chen Gong, Jesse Barnes, LKML, linux-pci@vger.kernel.org,
Hidetoshi Seto, Kenji Kaneshige, Matthew Garrett,
ACPI Devel Maling List
Hi, Rafael,
On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
> | OSC_PCI_EXPRESS_PME_CONTROL;
>
> if (pci_aer_available()) {
> - if (pcie_aer_get_firmware_first(port))
> + if (aer_acpi_firmware_first())
> dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> else
> flags |= OSC_PCI_EXPRESS_AER_CONTROL;
The original per-device firmware_first is overridden by the new global
firmware_first? If it is, why keep the original per-device
firmware_first?
Best Regards,
Huang Ying
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...)
2010-09-25 5:51 ` Huang Ying
@ 2010-09-25 20:37 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2010-09-25 20:37 UTC (permalink / raw)
To: Huang Ying
Cc: Chen Gong, Jesse Barnes, LKML, linux-pci@vger.kernel.org,
Hidetoshi Seto, Kenji Kaneshige, Matthew Garrett,
ACPI Devel Maling List
On Saturday, September 25, 2010, Huang Ying wrote:
> Hi, Rafael,
>
> On Tue, 2010-09-21 at 00:50 +0800, Rafael J. Wysocki wrote:
> > --- linux-2.6.orig/drivers/pci/pcie/portdrv_acpi.c
> > +++ linux-2.6/drivers/pci/pcie/portdrv_acpi.c
> > @@ -49,7 +49,7 @@ int pcie_port_acpi_setup(struct pci_dev
> > | OSC_PCI_EXPRESS_PME_CONTROL;
> >
> > if (pci_aer_available()) {
> > - if (pcie_aer_get_firmware_first(port))
> > + if (aer_acpi_firmware_first())
> > dev_dbg(&port->dev, "PCIe errors handled by BIOS.\n");
> > else
> > flags |= OSC_PCI_EXPRESS_AER_CONTROL;
>
> The original per-device firmware_first is overridden by the new global
> firmware_first? If it is, why keep the original per-device
> firmware_first?
I didn't want to remove it just yet, but I do think it should be removed.
Rafael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-25 20:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-19 22:02 [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence Rafael J. Wysocki
2010-09-20 6:18 ` Chen Gong
2010-09-20 16:50 ` [PATCH] PCI / PCIe / AER: Disable native AER service if BIOS has precedence (v2) (was: Re: [PATCH] PCI / PCIe / AER ...) Rafael J. Wysocki
2010-09-24 16:53 ` Jesse Barnes
2010-09-25 5:51 ` Huang Ying
2010-09-25 20:37 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).