From: Stefan Assmann <sassmann@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jan Beulich <JBeulich@novell.com>, Takashi Iwai <tiwai@suse.de>,
Junio C Hamano <gitster@pobox.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
Len Brown <lenb@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: lost parts of "pci, acpi: reroute PCI interrupt to legacy boot interrupt equivalent" during merge
Date: Wed, 20 Oct 2010 18:28:06 +0200 [thread overview]
Message-ID: <4CBF1896.70901@redhat.com> (raw)
In-Reply-To: <20101020152453.GD22271@elte.hu>
On 20.10.2010 17:24, Ingo Molnar wrote:
>
> * Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>> On Wed, Oct 20, 2010 at 6:48 AM, Ingo Molnar <mingo@elte.hu> wrote:
>>>
>>> I re-created the merge commit the following way:
>>>
>>> git checkout c2f4398 # has old drivers/acpi/pci_irq.c
>>> git merge 662c319 # contains new drivers/acpi/pci_irq.c bits
>>
>> The other way around. The c2f4398 version is the new one, the 662c319 is the old
>> one. So git picks the new one.
>
> Ah, indeed - i got confused by the fact that the newer tree had the 'older' content
> of drivers/acpi/pci_irq.c. (which was really a new version as you noted)
>
> Found the right commit as well - that chunk got zapped by:
>
> |
> | commit ec9f168fcc344d2ffec1c8c822076bf22dab5c33
> | Merge: b2576e1 087da3b
> | Author: Len Brown <len.brown@intel.com>
> | Date: Fri Jan 9 03:41:08 2009 -0500
> |
> | Merge branch 'simplify_PRT' into release
> |
> | Conflicts:
> | drivers/acpi/pci_irq.c
> |
> | Note that this merge disables
> | e1d3a90846b40ad3160bf4b648d36c6badad39ac
> | pci, acpi: reroute PCI interrupt to legacy boot interrupt equivalent
> |
> | Signed-off-by: Len Brown <len.brown@intel.com>
> |
>
> And was marked thusly by Len. So everything is in order - this chunk fell victim to
> non-trivial merge complications and needs a resurrection.
Let me take a look at the current situation and see if I can come up
with a solution. Sorry if things got messy.
Stefan
--
Stefan Assmann | Red Hat GmbH
Software Engineer | Otto-Hahn-Strasse 20, 85609 Dornach
| HR: Amtsgericht Muenchen HRB 153243
| GF: Brendan Lane, Charlie Peters,
sassmann at redhat.com | Michael Cunningham, Charles Cachera
next prev parent reply other threads:[~2010-10-20 16:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 10:03 lost parts of "pci, acpi: reroute PCI interrupt to legacy boot interrupt equivalent" during merge Jan Beulich
2010-10-20 13:48 ` Ingo Molnar
2010-10-20 15:15 ` Linus Torvalds
2010-10-20 15:24 ` Ingo Molnar
2010-10-20 16:28 ` Stefan Assmann [this message]
2010-10-20 18:14 ` Bjorn Helgaas
2010-10-20 19:54 ` Stefan Assmann
2010-10-20 21:31 ` Bjorn Helgaas
2010-10-21 18:20 ` Olaf Dabrunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBF1896.70901@redhat.com \
--to=sassmann@redhat.com \
--cc=JBeulich@novell.com \
--cc=gitster@pobox.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox