From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jiri Slaby <jslaby@suse.cz>, Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH 14/48] PM: Fix oops in suspend/hibernate code related to failing ioremap()
Date: Wed, 12 Jan 2011 12:21:13 -0800 [thread overview]
Message-ID: <4D2E0D39.1070003@oracle.com> (raw)
In-Reply-To: <201101122105.10132.rjw@sisk.pl>
On 01/12/11 12:05, Rafael J. Wysocki wrote:
> On Wednesday, January 12, 2011, Randy Dunlap wrote:
>> On 01/12/11 10:40, Randy Dunlap wrote:
>>> On Wed, 12 Jan 2011 19:39:19 +0100 Jiri Slaby wrote:
>>>
>>>> On 01/12/2011 11:19 AM, Len Brown wrote:
>>>>> @@ -271,7 +271,7 @@ static inline int suspend_nvs_register(unsigned long a, unsigned long b)
>>>>> }
>>>>> static inline int suspend_nvs_alloc(void) { return 0; }
>>>>> static inline void suspend_nvs_free(void) {}
>>>>> -static inline void suspend_nvs_save(void) {}
>>>>> +static inline int suspend_nvs_save(void) {}
>>>>
>>>> Aiee, I've just noticed, this needs to return something, otherwise a
>>>> warning is generated for !CONFIG_SUSPEND_NVS.
>>>>
>>>> What's better for you, a followup or resend?
>>>
>>> Yeah, I just made a patch for that, but I'll leave it up to
>>> you and Len to haggle about.
>
> We're removing CONFIG_SUSPEND_NVS in one of the later patches, but please send
> the fix if it's still necessary after applying the entire series.
Build fails in linux-next of 2011-0112. Does that have the entire series
applied?
>> Not that Len cares, but there is also this build error when
>> ACPI is not enabled:
>>
>> arch/x86/kernel/e820.c:734: error:implicit declaration of function 'suspend_nvs_register'
>>
>>
>> I also have a patch for it.
>
> Please submit it.
Did that.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2011-01-12 20:21 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 10:18 ACPI patches for 2.6.38-merge Len Brown
2011-01-12 10:18 ` [PATCH 01/48] PNP: Compile all pnp built-in stuff in one module namespace Len Brown
2011-01-12 10:18 ` [PATCH 02/48] PNP: Set up pnp_debug via module and not via boot param Len Brown
2011-01-12 10:18 ` [PATCH 03/48] thermal: make ops constant Len Brown
2011-01-12 10:18 ` [PATCH 04/48] Add CPER PCIe error section structure and constants definition Len Brown
2011-01-12 10:18 ` [PATCH 05/48] ACPI, APEI, Add APEI generic error status printing support Len Brown
2011-01-12 10:19 ` [PATCH 06/48] ACPI, APEI, Report GHES error information via printk Len Brown
2011-01-12 10:19 ` [PATCH 07/48] ACPI processor: remove processor throttling control procfs I/F Len Brown
2011-01-12 10:19 ` [PATCH 08/48] ACPI video: remove output switching control Len Brown
2011-01-12 10:19 ` [PATCH 09/48] ACPI video: check cap._DDC flag before getting EDID Len Brown
2011-01-12 10:19 ` [PATCH 10/48] ACPI video: introduce module parameter video.use_bios_initial_backlight Len Brown
2011-01-12 10:19 ` [PATCH 11/48] IPMI: Add one interface to get more info of low-level IPMI device Len Brown
2011-01-12 10:19 ` [PATCH 12/48] IPMI: Add the document description of ipmi_get_smi_info Len Brown
2011-01-12 10:19 ` [PATCH 13/48] IPMI/ACPI: Add the IPMI opregion driver to enable ACPI to access BMC controller Len Brown
2011-01-12 10:19 ` [PATCH 14/48] PM: Fix oops in suspend/hibernate code related to failing ioremap() Len Brown
2011-01-12 18:39 ` Jiri Slaby
2011-01-12 18:40 ` Randy Dunlap
2011-01-12 18:42 ` Randy Dunlap
2011-01-12 20:05 ` Rafael J. Wysocki
2011-01-12 20:21 ` Randy Dunlap [this message]
2011-01-12 20:29 ` Rafael J. Wysocki
2011-01-12 20:32 ` Randy Dunlap
2011-01-12 10:19 ` [PATCH 15/48] PM / ACPI: Move NVS saving and restoring code to drivers/acpi Len Brown
2011-01-12 10:19 ` [PATCH 16/48] ACPI / PM: Update file information and the list of includes in nvs.c Len Brown
2011-01-12 10:19 ` [PATCH 17/48] ACPI / PM: Make suspend_nvs_save() use acpi_os_map_memory() Len Brown
2011-01-12 10:19 ` [PATCH 18/48] ACPI: Use ioremap_cache() Len Brown
2011-01-12 10:19 ` [PATCH 19/48] ACPI / ACPICA: Fix global lock acquisition Len Brown
2011-01-12 10:19 ` [PATCH 20/48] ACPI / PM: Do not enable multiple devices to wake up simultaneously Len Brown
2011-01-12 10:19 ` [PATCH 21/48] ACPI / PM: Use device wakeup flags for handling ACPI wakeup devices Len Brown
2011-01-12 10:19 ` [PATCH 22/48] ACPI / PM: Drop special ACPI wakeup flags Len Brown
2011-01-12 10:19 ` [PATCH 23/48] ACPI / PM: Report wakeup events from buttons Len Brown
2011-01-12 10:19 ` [PATCH 24/48] ACPI / PM: Blacklist Averatec machine known to require acpi_sleep=nonvs Len Brown
2011-01-12 10:19 ` [PATCH 25/48] ACPI: Check the returned value of set_cpus_allowed_ptr before T-state operation Len Brown
2011-01-12 10:19 ` [PATCH 26/48] ACPI: Reevaluate whether the T-state is supported or not after cpu is online/offline Len Brown
2011-01-12 10:19 ` [PATCH 27/48] PNP / ACPI: Use DEVICE_ACPI_HANDLE() for device ACPI handle access Len Brown
2011-01-12 10:19 ` [PATCH 28/48] thermal: Add event notification to thermal framework Len Brown
2011-01-13 11:07 ` Thomas Renninger
2011-01-13 11:14 ` Thomas Renninger
2011-01-13 11:21 ` Thomas Renninger
2011-01-13 11:31 ` R, Durgadoss
2011-01-13 11:47 ` Thomas Renninger
2011-01-13 12:36 ` R, Durgadoss
2011-01-13 13:41 ` Thomas Renninger
2011-01-14 3:35 ` Len Brown
2011-01-14 9:58 ` Thomas Renninger
2011-01-12 10:19 ` [PATCH 29/48] ACPI: update CONFIG_ACPI_PROCFS description Len Brown
2011-01-12 10:19 ` [PATCH 30/48] ACPI: delete CONFIG_ACPI_PROCFS_POWER and power procfs I/F in 2.6.39 Len Brown
2011-01-12 10:19 ` [PATCH 31/48] ACPI, APEI, Generic Hardware Error Source POLL/IRQ/NMI notification type support Len Brown
2011-01-12 10:19 ` [PATCH 32/48] ACPI / PM: Prevent acpi_power_get_inferred_state() from making changes Len Brown
2011-01-12 10:19 ` [PATCH 33/48] ACPI / PM: Add functions for manipulating lists of power resources Len Brown
2011-01-12 10:19 ` [PATCH 34/48] ACPI / PM: Introduce function for refcounting device " Len Brown
2011-01-12 10:19 ` [PATCH 35/48] ACPI / PM: Introduce __acpi_bus_get_power() Len Brown
2011-01-12 10:19 ` [PATCH 36/48] ACPI / PM: Add function for device power state initialization Len Brown
2011-01-12 10:19 ` [PATCH 37/48] ACPI / PM: Add function for updating device power state consistently Len Brown
2011-01-12 10:19 ` [PATCH 38/48] ACPI / PM: Register acpi_power_driver early Len Brown
2011-01-12 10:19 ` [PATCH 39/48] ACPI / PM: Register power resource devices as soon as they are needed Len Brown
2011-01-12 10:19 ` [PATCH 40/48] ACPI / Fan: Rework the handling of power resources Len Brown
2011-01-12 10:19 ` [PATCH 41/48] Platform / x86: Make fujitsu_laptop use acpi_bus_update_power() Len Brown
2011-01-12 10:19 ` [PATCH 42/48] ACPI / PM: Drop acpi_bus_get_power() Len Brown
2011-01-12 10:19 ` [PATCH 43/48] ACPI / PM: Drop acpi_power_nocheck Len Brown
2011-01-12 10:19 ` [PATCH 44/48] ACPI / PM: Rename acpi_power_off_device() Len Brown
2011-01-12 10:19 ` [PATCH 45/48] ACPI / PM: Check status of power resources under mutexes Len Brown
2011-01-12 10:19 ` [PATCH 46/48] ACPI: Always check if _PRW is present before trying to evaluate it Len Brown
2011-01-12 10:19 ` [PATCH 47/48] ACPI: Drop device flag wake_capable Len Brown
2011-01-12 10:19 ` [PATCH 48/48] ACPI / Battery: Update information on info notification and resume Len Brown
2011-01-12 15:23 ` ACPI patches for 2.6.38-merge Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2E0D39.1070003@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=jslaby@suse.cz \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox