From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Travis Subject: Re: [PATCH 1/6] printk: Allocate kernel log buffer earlier Date: Thu, 20 Jan 2011 15:55:30 -0800 Message-ID: <4D38CB72.2060503@sgi.com> References: <20110119230106.341785959@gulag1.americas.sgi.com> <20110119230106.527741713@gulag1.americas.sgi.com> <20110120155021.c39387c3.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110120155021.c39387c3.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: Ingo Molnar , Len Brown , "H. Peter Anvin" , Thomas Gleixner , Jack Steiner , Robin Holt , Lori Gilbertson , x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org List-Id: linux-acpi@vger.kernel.org Andrew Morton wrote: > On Wed, 19 Jan 2011 17:01:07 -0600 > Mike Travis wrote: > >> On larger systems, because of the numerous ACPI, Bootmem and EFI >> messages, the static log buffer overflows before the larger one >> specified by the log_buf_len param is allocated. Minimize the >> overflow by allocating the new log buffer as soon as possible. >> >> All arch's are covered by the "setup_log_buf" in start_kernel(). >> The x86 arch allocates it right after bootmem is created. >> >> ... >> >> +void setup_log_buf(void); >> >> ... >> >> +void __init setup_log_buf(void) >> > > It's a PITA but the declaration should have the __init tag as well. We > have had at least one instance where failing to do this caused an arch > (arm) to emit a short-mode address offset to a function which it > thought was in the same section as the callsite. Only the target was > in a different section from the callsite and the linker couldn't fit > the needed offset into the operand. > That reminds me of another question. If I have: void __init setup(void) { static int data; ... Does data automatically get put into the initdata section? Or does it need the __initdata tag as well? Thanks, Mike