From: Huang Ying <ying.huang@intel.com>
To: "Wu, Fengguang" <fengguang.wu@intel.com>
Cc: Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
"Luck, Tony" <tony.luck@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC 1/4] HWPoison: add memory_failure_queue()
Date: Thu, 21 Apr 2011 14:38:42 +0800 [thread overview]
Message-ID: <4DAFD0F2.5080708@intel.com> (raw)
In-Reply-To: <20110420090305.GB3761@localhost>
Hi, Fengguang,
On 04/20/2011 05:03 PM, Wu, Fengguang wrote:
>> + if (kfifo_put(&mf_cpu->fifo, &entry))
>> + schedule_work_on(smp_processor_id(), &mf_cpu->work);
>> + else
>> + pr_err("Memory failure: buffer overflow when recovering memory failure at 0x%#lx\n",
>> + pfn);
>
> nitpick: "buffer overflow when recording memory failure at PFN ..."?
Yes, in fact we are not recovering now. Or "s/recording/queuing/"?
Best Regards,
Huang Ying
next prev parent reply other threads:[~2011-04-21 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-19 1:43 [RFC 1/4] HWPoison: add memory_failure_queue() Huang Ying
2011-04-19 1:43 ` [RFC 2/4] ACPI, APEI, GHES: Add hardware memory error recovery support Huang Ying
2011-04-19 1:43 ` [RFC 3/4] PCIe, AER, add aer_recover_queue Huang Ying
2011-04-19 1:43 ` [RFC 4/4] ACPI, APEI, GHES: Add PCIe AER recovery support Huang Ying
2011-04-20 9:03 ` [RFC 1/4] HWPoison: add memory_failure_queue() Wu Fengguang
2011-04-21 6:38 ` Huang Ying [this message]
2011-04-21 10:05 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAFD0F2.5080708@intel.com \
--to=ying.huang@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=fengguang.wu@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).