From: Huang Ying <ying.huang@intel.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Len Brown <lenb@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [BUGFIX] ACPI, APEI, EINJ Param support is disabled by default
Date: Thu, 21 Jul 2011 12:27:05 +0800 [thread overview]
Message-ID: <4E27AA99.4000102@intel.com> (raw)
In-Reply-To: <20110721041610.GL8006@one.firstfloor.org>
On 07/21/2011 12:16 PM, Andi Kleen wrote:
> On Thu, Jul 21, 2011 at 10:54:13AM +0800, Huang Ying wrote:
>> On 07/21/2011 10:42 AM, Andi Kleen wrote:
>>>>
>>>> +static bool param_extension;
>>>> +module_param(param_extension, bool, 0);
>>>
>>> Make it 0644, then it can be changed at runtime. No need to require a reboot.
>>
>> Normally, EINJ is compiled as module, so we can change it at load time
>> without a reboot.
>
> Ok.
>
>>
>> Do we need the real runtime switching capability?
>
> I usually do that with modparams when it's possible. After all it's very
> simple and doesn't cost anything.
To avoid confuse user, the param1/param2 files are created only if
param_extension=y is specified. So making modprams changeable in run
time may make situation a little complex.
Best Regards,
Huang Ying
next prev parent reply other threads:[~2011-07-21 4:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-20 8:09 [BUGFIX] ACPI, APEI, EINJ Param support is disabled by default Huang Ying
2011-07-20 15:22 ` Bjorn Helgaas
2011-07-21 1:02 ` Huang Ying
2011-07-21 4:46 ` Bjorn Helgaas
2011-07-21 5:14 ` Huang Ying
2011-07-21 2:42 ` Andi Kleen
2011-07-21 2:54 ` Huang Ying
2011-07-21 4:16 ` Andi Kleen
2011-07-21 4:27 ` Huang Ying [this message]
2011-07-21 4:50 ` Andi Kleen
2011-08-02 22:03 ` Len Brown
2011-08-03 0:37 ` Huang Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E27AA99.4000102@intel.com \
--to=ying.huang@intel.com \
--cc=andi@firstfloor.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox