From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Ying Subject: Re: [BUGFIX] ACPI, APEI, EINJ Param support is disabled by default Date: Thu, 21 Jul 2011 12:27:05 +0800 Message-ID: <4E27AA99.4000102@intel.com> References: <1311149369-20624-1-git-send-email-ying.huang@intel.com> <20110721024204.GJ8006@one.firstfloor.org> <4E2794D5.1030104@intel.com> <20110721041610.GL8006@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110721041610.GL8006@one.firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org To: Andi Kleen Cc: Len Brown , "linux-kernel@vger.kernel.org" , "Luck, Tony" , "linux-acpi@vger.kernel.org" , Matthew Garrett List-Id: linux-acpi@vger.kernel.org On 07/21/2011 12:16 PM, Andi Kleen wrote: > On Thu, Jul 21, 2011 at 10:54:13AM +0800, Huang Ying wrote: >> On 07/21/2011 10:42 AM, Andi Kleen wrote: >>>> >>>> +static bool param_extension; >>>> +module_param(param_extension, bool, 0); >>> >>> Make it 0644, then it can be changed at runtime. No need to require a reboot. >> >> Normally, EINJ is compiled as module, so we can change it at load time >> without a reboot. > > Ok. > >> >> Do we need the real runtime switching capability? > > I usually do that with modparams when it's possible. After all it's very > simple and doesn't cost anything. To avoid confuse user, the param1/param2 files are created only if param_extension=y is specified. So making modprams changeable in run time may make situation a little complex. Best Regards, Huang Ying