public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Brown, Len" <len.brown@intel.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] Convert width in bits to bytes in __acpi_ioremap_fast()
Date: Tue, 25 Oct 2011 10:48:54 +0800	[thread overview]
Message-ID: <4EA62396.2070002@intel.com> (raw)
In-Reply-To: <4ea1e75f5296b6c6b@agluck-desktop.sc.intel.com>

Sorry for late.

On 10/22/2011 05:42 AM, Luck, Tony wrote:
> Callers to __acpi_ioremap_fast() pass the bit_width that they found in the
> acpi_generic_address structure. Convert from bits to bytes when passing to
> __acpi_find_iomap() - as it wants to see bytes, not bits.
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/acpi/atomicio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/acpi/atomicio.c b/drivers/acpi/atomicio.c
> index 252888f..70ffb71 100644
> --- a/drivers/acpi/atomicio.c
> +++ b/drivers/acpi/atomicio.c
> @@ -78,7 +78,7 @@ static void __iomem *__acpi_ioremap_fast(phys_addr_t paddr,
>  {
>  	struct acpi_iomap *map;
>  
> -	map = __acpi_find_iomap(paddr, size);
> +	map = __acpi_find_iomap(paddr, size/8);
>  	if (map)
>  		return map->vaddr + (paddr - map->paddr);
>  	else

Good catch! Thanks.

Or change the caller acpi_atomic_read_mem/write_mem?

Best Regards,
Huang Ying

  reply	other threads:[~2011-10-25  2:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21 21:42 [PATCH] Convert width in bits to bytes in __acpi_ioremap_fast() Luck, Tony
2011-10-25  2:48 ` Huang Ying [this message]
2011-10-25 13:57   ` Bjorn Helgaas
2011-10-25 18:39     ` Luck, Tony
2011-10-25 19:34       ` Bjorn Helgaas
2011-10-25 20:03         ` Myron Stowe
2011-10-28  0:17 ` Thomas Renninger
2011-11-07  1:29   ` Len Brown
2011-11-07  3:28     ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA62396.2070002@intel.com \
    --to=ying.huang@intel.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox