On 2011/11/8 1:37, Len Brown wrote: > It doesn't apply for me, and it looks white-space damaged. > Does it pass checkpatch.pl for you and apply for you? > Possibly an issue with my new gmail setup, > but it looks more like this was damaged at the source. > > > ERROR: code indent should use tabs where possible > #103: FILE: drivers/acpi/processor_driver.c:668: > + acpi_bus_hot_remove_device(handle);$ > > WARNING: please, no spaces at the start of a line > #103: FILE: drivers/acpi/processor_driver.c:668: > + acpi_bus_hot_remove_device(handle);$ > > WARNING: please, no spaces at the start of a line > #125: FILE: drivers/acpi/scan.c:132: > + if (ACPI_FAILURE(status)&& (status != AE_NOT_FOUND))$ > > WARNING: suspect code indent for conditional statements (4, 9) > #125: FILE: drivers/acpi/scan.c:132: > + if (ACPI_FAILURE(status)&& (status != AE_NOT_FOUND)) > printk(KERN_WARNING PREFIX > Hi Len, Because I copy the patch to the email and my git proxy is not ready in window. Please use the attachment to apply. it passed by checkpatch.pl. I will install the git in linux server. and later I will use it to send the patch. Thanks, Canquan.shen