From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: akpm@linux-foundation.org
Cc: lenb@kernel.org, len.brown@intel.com, linux-acpi@vger.kernel.org,
yanmin_zhang@linux.intel.com, mingmingx.zhang@intel.com,
shaohua.li@intel.com
Subject: Re: [patch 3/3] drivers/idle/intel_idle.c: remove redundant local_irq_disable() call
Date: Wed, 11 Jan 2012 21:29:44 +0530 [thread overview]
Message-ID: <4F0DB1F0.1060408@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120110234821.E8BF5100270@wpzn3.hot.corp.google.com>
On 01/11/2012 05:18 AM, akpm@linux-foundation.org wrote:
> From: Yanmin Zhang <yanmin_zhang@linux.intel.com>
> Subject: drivers/idle/intel_idle.c: remove redundant local_irq_disable() call
>
> irq disabling happens earlier in process_32.c:cpu_idle. Basically,
> cpuidle_state->enter is called, cpu irq is disabled. cpuidle_state->enter
> would turn on irq when exiting.
>
> intel_idle doesn't follow this assumption. Although it doesn't cause real
> issue, it misleads developers. Remove the call to local_irq_disable() at
> entry.
>
> [akpm@linux-foundation.org: add comment]
> Signed-off-by: mzha38X <mingmingx.zhang@intel.com>
^^^^^^^
Are nicknames acceptable? AFAIK, real names are preferred...
> Cc: "Li, Shaohua" <shaohua.li@intel.com>
> Cc: "Brown, Len" <len.brown@intel.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
next prev parent reply other threads:[~2012-01-11 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 23:48 [patch 3/3] drivers/idle/intel_idle.c: remove redundant local_irq_disable() call akpm
2012-01-11 15:59 ` Srivatsa S. Bhat [this message]
2012-01-17 12:22 ` Thomas Renninger
2012-01-18 0:15 ` Yanmin Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0DB1F0.1060408@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=mingmingx.zhang@intel.com \
--cc=shaohua.li@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).