public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@de.bosch.com>
To: Robert Lee <rob.lee@linaro.org>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"patches@linaro.org" <patches@linaro.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"amit.kucheria@linaro.org" <amit.kucheria@linaro.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	Eric Miao <eric.miao@linaro.org>,
	"shawn.guo@freescale.com" <shawn.guo@freescale.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"lenb@kernel.org" <lenb@kernel.org>
Subject: Re: [RFC] ARM: imx: Add imx6q thermal
Date: Thu, 12 Jan 2012 08:15:09 +0100	[thread overview]
Message-ID: <4F0E887D.2090009@de.bosch.com> (raw)
In-Reply-To: <1326266285-11656-1-git-send-email-rob.lee@linaro.org>

Hi Rob,

On 11.01.2012 08:18, Robert Lee wrote:
> Add thermal support for i.MX6Q.  Uses recently submitted common
> cpu_cooling functionality shown here:
> 
> http://www.spinics.net/lists/linux-pm/msg26500.html
> 
> Have some todo items but basic implementation is done and I'd like to
> get any helpful feedback on it.
> 
> Todo:
> - Add sensor calibration.
> - Re-organize code/files if deemed necessary by community.

Just fyi, I had a short discussion with Eric Miao about this. The 
conclusion was:

The patch itself is OK. It's just lacking some features, but these can 
be added later. The driver supports thermal reading only, but not 
accurate as the thermal calibration data is burned into the FUSE, and 
differ from chip to chip. At the moment only incorrect thermal 
information will be exposed to user space. The patch is lacking 
connections to cpufreq and cpu hotplug, but those could be added later, too.

Best regards

Dirk

  reply	other threads:[~2012-01-12  7:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  7:18 [RFC] ARM: imx: Add imx6q thermal Robert Lee
2012-01-12  7:15 ` Dirk Behme [this message]
2012-01-12 20:47   ` Rob Lee
2012-01-12  9:36 ` Sascha Hauer
2012-01-13  0:11   ` Rob Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0E887D.2090009@de.bosch.com \
    --to=dirk.behme@de.bosch.com \
    --cc=amit.kucheria@linaro.org \
    --cc=eric.miao@linaro.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=patches@linaro.org \
    --cc=rob.lee@linaro.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox