From: Chen Gong <gong.chen@linux.intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] ACPI, APEI: Add validation check before GHES error is recorded
Date: Sat, 31 Mar 2012 09:53:05 +0800 [thread overview]
Message-ID: <4F766381.4040104@linux.intel.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F15B73074@ORSMSX104.amr.corp.intel.com>
于 2012/3/30 1:07, Luck, Tony 写道:
> + if (mem_err->validation_bits& CPER_MEM_VALID_PHYSICAL_ADDRESS)
> + m.addr = mem_err->physical_addr;
>
> At the moment "addr" is the only useful value in this record ... so
> if we find that we can't supply it because we don't know it - then the
> record has no value, and we might as well not send it.
>
> E.g. start the function with:
>
> if (!(mem_err->validation_bits& CPER_MEM_VALID_PHYSICAL_ADDRESS))
> return;
>
> -Tony
>
But as Ying said before, in theory we need to support this scenario,
otherwise, I prefer to
add check condition out of this function, not here.
What's your opinion, Ying?
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-03-31 1:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-29 7:09 [PATCH] ACPI, APEI: Add validation check before GHES error is recorded Chen Gong
2012-03-29 17:07 ` Luck, Tony
2012-03-31 1:53 ` Chen Gong [this message]
2012-03-31 3:24 ` Huang Ying
2012-03-31 5:45 ` Chen Gong
2012-03-31 5:54 ` [PATCH V2] " Chen Gong
2012-04-02 15:47 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F766381.4040104@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox