From: Len Brown <lenb@kernel.org>
To: Lin Ming <ming.m.lin@intel.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-acpi <linux-acpi@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
aaron.lu@amd.com
Subject: Re: [PATCH v3] ACPI: D3 states cleanup
Date: Sat, 05 May 2012 01:24:34 -0400 [thread overview]
Message-ID: <4FA4B992.2010808@kernel.org> (raw)
In-Reply-To: <1335143029.4927.45.camel@minggr>
Applied using updated check-in comment below.
thanks,
-Len Brown, Intel Open Source Technology Center
From: Lin Ming <ming.m.lin@intel.com>
Subject: [PATCH] ACPI: Fix D3hot v D3cold confusion
Before this patch, ACPI_STATE_D3 incorrectly referenced D3hot
in some places, but D3cold in other places.
After this patch, ACPI_STATE_D3 always means ACPI_STATE_D3_COLD;
and all references to D3hot use ACPI_STATE_D3_HOT.
ACPI's _PR3 method is used to enter both D3hot and D3cold states.
What distinguishes D3hot from D3cold is the presence _PR3
(Power Resources for D3hot) If these resources are all ON,
then the state is D3hot. If _PR3 is not present,
or all _PR0 resources for the devices are OFF,
then the state is D3cold.
This patch applies after Linux-3.4-rc1.
A future syntax cleanup may remove ACPI_STATE_D3
to emphasize that it always means ACPI_STATE_D3_COLD.
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Aaron Lu <aaron.lu@amd.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
drivers/acpi/power.c | 2 +-
drivers/acpi/scan.c | 17 +++++++----------
drivers/pci/pci-acpi.c | 4 ++--
include/acpi/actypes.h | 7 ++++---
4 files changed, 14 insertions(+), 16 deletions(-)
prev parent reply other threads:[~2012-05-05 5:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 1:03 [PATCH v3] ACPI: D3 states cleanup Lin Ming
2012-04-23 1:52 ` Aaron Lu
2012-05-04 5:23 ` Lin Ming
2012-04-27 7:48 ` huang ying
2012-05-05 5:24 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4B992.2010808@kernel.org \
--to=lenb@kernel.org \
--cc=aaron.lu@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).