From: Len Brown <lenb@kernel.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
ming.m.lin@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-acpi@vger.kernel.org,
x86@kernel.org, "Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 2/2] x86/acpi: Call acpi_enter_sleep_state via an asmlinkage C function from assembler.
Date: Tue, 08 May 2012 02:35:25 -0400 [thread overview]
Message-ID: <4FA8BEAD.8070806@kernel.org> (raw)
In-Reply-To: <201204182302.51868.rjw@sisk.pl>
On 04/18/2012 05:02 PM, Rafael J. Wysocki wrote:
> On Wednesday, April 18, 2012, H. Peter Anvin wrote:
>> On 04/18/2012 10:18 AM, Konrad Rzeszutek Wilk wrote:
>>>
>>> Suggested-by: H. Peter Anvin <hpa@zytor.com>
>>> [v2: Remove extra assembler operations, per hpa review]
>>> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>
>> Reviewed-by: H. Peter Anvin <hpa@zytor.com>
>>
>> Len, your tree or mine?
I think it was a mistake to apply this.
Instead we should have removed the code that it fixed.
-Len
next prev parent reply other threads:[~2012-05-08 6:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 17:18 [PATCH] gts and bfs fixes (v4) Konrad Rzeszutek Wilk
2012-04-18 17:18 ` [PATCH 1/2] ACPI: Convert wake_sleep_flags to a value instead of function (v4) Konrad Rzeszutek Wilk
2012-04-18 19:46 ` Rafael J. Wysocki
2012-04-18 17:18 ` [PATCH 2/2] x86/acpi: Call acpi_enter_sleep_state via an asmlinkage C function from assembler Konrad Rzeszutek Wilk
2012-04-18 19:48 ` Rafael J. Wysocki
2012-04-18 20:49 ` H. Peter Anvin
2012-04-18 21:02 ` Rafael J. Wysocki
2012-05-08 6:35 ` Len Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-17 18:29 [PATCH] gts and bfs fixes (v3) Konrad Rzeszutek Wilk
2012-04-17 18:29 ` [PATCH 2/2] x86/acpi: Call acpi_enter_sleep_state via an asmlinkage C function from assembler Konrad Rzeszutek Wilk
2012-04-17 18:36 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA8BEAD.8070806@kernel.org \
--to=lenb@kernel.org \
--cc=hpa@zytor.com \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).