From: Lan Tianyu <tianyu.lan@intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: lenb@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-acpi@vger.kernel.org,
sarah.a.sharp@linux.intel.com
Subject: Re: [PATCH 2/3] usb/acpi: add the support of usb hub ports' acpi binding without attached devices.
Date: Mon, 14 May 2012 22:09:02 +0800 [thread overview]
Message-ID: <4FB111FE.80500@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1205140957230.1699-100000@iolanthe.rowland.org>
On 2012/5/14 21:58, Alan Stern wrote:
> On Mon, 14 May 2012, Lan Tianyu wrote:
>
>> The usb port is a device in the acpi table but it's not in the linux
>> usb subsystem. USB hub port doesn't have struct device. So the acpi
>> glue framework only can cover the usb port connected with usb device
>> and store the acpi handle to struct device.archdata.acpi_handle. This
>> patch is to add member port_acpi_handle in the struct usb_hub_port to
>> store acpi handle. The acpi method "_UPC" and "_PLD" can be accessed
>> without attached device.
>> --- a/drivers/usb/core/usb-acpi.c
>> +++ b/drivers/usb/core/usb-acpi.c
>> @@ -83,7 +83,16 @@ static int usb_acpi_find_device(struct device *dev, acpi_handle *handle)
>> if (!parent_handle)
>> return -ENODEV;
>>
>> - *handle = acpi_get_child(parent_handle, udev->portnum);
>> + /**
>> + * The root hub's acpi handle is got from acpi method.
>> + * Other device's acpi handle can be got from the usb hub
>> + * port's platform_data.
>> + */
> The /** pattern is reserved for kerneldoc comments, which appear only
> at the start of a function. Within a function you should use the
> normal /* comment pattern.
Ok. Thanks for review.
>
> Alan Stern
>
--
Best Regards
Tianyu Lan
linux kernel enabling team
next prev parent reply other threads:[~2012-05-14 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1337001268-3100-1-git-send-email-tianyu.lan@intel.com>
2012-05-14 13:14 ` [PATCH 2/3] usb/acpi: add the support of usb hub ports' acpi binding without attached devices Lan Tianyu
2012-05-14 13:58 ` Alan Stern
2012-05-14 14:09 ` Lan Tianyu [this message]
[not found] ` <1337001268-3100-1-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-05-14 13:14 ` [PATCH 3/3] usb/acpi: add usb check for the connect type of usb port Lan Tianyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB111FE.80500@intel.com \
--to=tianyu.lan@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).