* ACPI ALS Status ?
@ 2011-11-06 19:34 Corentin Chary
2011-11-06 22:16 ` Len Brown
0 siblings, 1 reply; 9+ messages in thread
From: Corentin Chary @ 2011-11-06 19:34 UTC (permalink / raw)
To: Zhang, Rui; +Cc: Pavel Machek, Dmitry Torokhov, linux acpi
Hi,
I was looking at the DSDT of a new samsung laptop (I can send you the
output of acpidump if interested), and it export a standard ACPI ALS
device. So, it's actually great to see vendor using that, but it seems
that the series adding support for that and sent back in 2009 is not
available in the kernel. I'd really like to use my the ALS, what's the
current status of the driver ? Still blocked because we don't have a
generic sysfs class ? If yes, can't we just use a non-standard
interface ? It would still be better than no driver at all.
Thanks,
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2011-11-06 19:34 ACPI ALS Status ? Corentin Chary
@ 2011-11-06 22:16 ` Len Brown
[not found] ` <CAHR064hprC29+4wso1nR8cL4ZDXEqj7CONF6h2cdyeuHxmkjiw@mail.gmail.com>
2012-03-05 9:12 ` Corentin Chary
0 siblings, 2 replies; 9+ messages in thread
From: Len Brown @ 2011-11-06 22:16 UTC (permalink / raw)
To: Corentin Chary; +Cc: Zhang, Rui, Pavel Machek, Dmitry Torokhov, linux acpi
> I was looking at the DSDT of a new samsung laptop (I can send you the
> output of acpidump if interested), and it export a standard ACPI ALS
> device. So, it's actually great to see vendor using that, but it seems
> that the series adding support for that and sent back in 2009 is not
> available in the kernel. I'd really like to use my the ALS, what's the
> current status of the driver ? Still blocked because we don't have a
> generic sysfs class ? If yes, can't we just use a non-standard
> interface ? It would still be better than no driver at all.
Yes, I think ACPI ALS support has been waiting for hardware to justify
its existence.
When it first entered the spec, we were excited to see it was present
in some high-end laptops, but IIR on closer examination the AML turned
out to be dummy code.
If you can verify that your Samsung really does implement ACPI ALS,
then that is all we need to stumble forward.
thanks,
-Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
[not found] ` <CAHR064hprC29+4wso1nR8cL4ZDXEqj7CONF6h2cdyeuHxmkjiw@mail.gmail.com>
@ 2011-12-03 9:43 ` Corentin Chary
2012-01-30 8:28 ` Corentin Chary
0 siblings, 1 reply; 9+ messages in thread
From: Corentin Chary @ 2011-12-03 9:43 UTC (permalink / raw)
To: Len Brown; +Cc: Zhang, Rui, Dmitry Torokhov, linux acpi
On Sun, Nov 6, 2011 at 11:51 PM, Corentin Chary
<corentin.chary@gmail.com> wrote:
> On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
>>> I was looking at the DSDT of a new samsung laptop (I can send you the
>>> output of acpidump if interested), and it export a standard ACPI ALS
>>> device. So, it's actually great to see vendor using that, but it seems
>>> that the series adding support for that and sent back in 2009 is not
>>> available in the kernel. I'd really like to use my the ALS, what's the
>>> current status of the driver ? Still blocked because we don't have a
>>> generic sysfs class ? If yes, can't we just use a non-standard
>>> interface ? It would still be better than no driver at all.
>>
>> Yes, I think ACPI ALS support has been waiting for hardware to justify
>> its existence.
>>
>> When it first entered the spec, we were excited to see it was present
>> in some high-end laptops, but IIR on closer examination the AML turned
>> out to be dummy code.
>>
>> If you can verify that your Samsung really does implement ACPI ALS,
>> then that is all we need to stumble forward.
I just found some time to try the latest patch series I could found on
gmane (v6 I think).
Here are the results:
$ uname -s -r
Linux 3.0.0-14-generic
$ tree -L 1 /sys/class/als/acpi_als0/
/sys/class/als/acpi_als0/
├── device -> ../../../LNXSYSTM:00/device:00/PNP0A08:00/device:02/PNP0C09:00/ACPI0008:00
├── display_adjustment
├── illuminance
├── power
├── subsystem -> ../../../../class/als
└── uevent
// light off
$ cat display_adjustment
23%
$ cat illuminance
7
// light on
$ cat display_adjustment
74%
$ cat illuminance
368
// finger on sensor
$ cat display_adjustment
7%
$ cat illuminance
1
So, it works perfectly, and since I've just added keyboard backlight
support in samsung-laptop, that would be the last (kernel) bit to
enable automagic screen/keyboard backlight :).
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2011-12-03 9:43 ` Corentin Chary
@ 2012-01-30 8:28 ` Corentin Chary
0 siblings, 0 replies; 9+ messages in thread
From: Corentin Chary @ 2012-01-30 8:28 UTC (permalink / raw)
To: Len Brown; +Cc: Zhang, Rui, Dmitry Torokhov, linux acpi
On Sat, Dec 3, 2011 at 10:43 AM, Corentin Chary
<corentin.chary@gmail.com> wrote:
> On Sun, Nov 6, 2011 at 11:51 PM, Corentin Chary
> <corentin.chary@gmail.com> wrote:
>> On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
>>>> I was looking at the DSDT of a new samsung laptop (I can send you the
>>>> output of acpidump if interested), and it export a standard ACPI ALS
>>>> device. So, it's actually great to see vendor using that, but it seems
>>>> that the series adding support for that and sent back in 2009 is not
>>>> available in the kernel. I'd really like to use my the ALS, what's the
>>>> current status of the driver ? Still blocked because we don't have a
>>>> generic sysfs class ? If yes, can't we just use a non-standard
>>>> interface ? It would still be better than no driver at all.
>>>
>>> Yes, I think ACPI ALS support has been waiting for hardware to justify
>>> its existence.
>>>
>>> When it first entered the spec, we were excited to see it was present
>>> in some high-end laptops, but IIR on closer examination the AML turned
>>> out to be dummy code.
>>>
>>> If you can verify that your Samsung really does implement ACPI ALS,
>>> then that is all we need to stumble forward.
>
> I just found some time to try the latest patch series I could found on
> gmane (v6 I think).
> Here are the results:
>
> $ uname -s -r
> Linux 3.0.0-14-generic
>
> $ tree -L 1 /sys/class/als/acpi_als0/
> /sys/class/als/acpi_als0/
> ├── device -> ../../../LNXSYSTM:00/device:00/PNP0A08:00/device:02/PNP0C09:00/ACPI0008:00
> ├── display_adjustment
> ├── illuminance
> ├── power
> ├── subsystem -> ../../../../class/als
> └── uevent
>
> // light off
> $ cat display_adjustment
> 23%
> $ cat illuminance
> 7
>
> // light on
> $ cat display_adjustment
> 74%
> $ cat illuminance
> 368
>
> // finger on sensor
> $ cat display_adjustment
> 7%
> $ cat illuminance
> 1
>
> So, it works perfectly, and since I've just added keyboard backlight
> support in samsung-laptop, that would be the last (kernel) bit to
> enable automagic screen/keyboard backlight :).
Hi,
Any plan to revive this driver for 3.4 or 3.5 ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2011-11-06 22:16 ` Len Brown
[not found] ` <CAHR064hprC29+4wso1nR8cL4ZDXEqj7CONF6h2cdyeuHxmkjiw@mail.gmail.com>
@ 2012-03-05 9:12 ` Corentin Chary
2012-05-20 13:09 ` Corentin Chary
1 sibling, 1 reply; 9+ messages in thread
From: Corentin Chary @ 2012-03-05 9:12 UTC (permalink / raw)
To: Len Brown; +Cc: Zhang, Rui, Pavel Machek, Dmitry Torokhov, linux acpi
On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
>> I was looking at the DSDT of a new samsung laptop (I can send you the
>> output of acpidump if interested), and it export a standard ACPI ALS
>> device. So, it's actually great to see vendor using that, but it seems
>> that the series adding support for that and sent back in 2009 is not
>> available in the kernel. I'd really like to use my the ALS, what's the
>> current status of the driver ? Still blocked because we don't have a
>> generic sysfs class ? If yes, can't we just use a non-standard
>> interface ? It would still be better than no driver at all.
>
> Yes, I think ACPI ALS support has been waiting for hardware to justify
> its existence.
>
> When it first entered the spec, we were excited to see it was present
> in some high-end laptops, but IIR on closer examination the AML turned
> out to be dummy code.
>
> If you can verify that your Samsung really does implement ACPI ALS,
> then that is all we need to stumble forward.
>
> thanks,
> -Len Brown, Intel Open Source Technology Center
Hello,
As stated in my previous mails, the implementation on this laptop is
perfectly functional, and since Windows 7 seems to be able to use
ACPI ALS nativelly [1] I suspect new (high end ?) laptop will all
support that.
Is there any plan to revive this driver for 3.4 or 3.5 ? Should
someone repost the last version of the previous patchset for
discussion ?
And no, on this laptop ALS is definitively not a gadget.
Thanks,
- http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx
--
Corentin Chary
http://xf.iksaif.net
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2012-03-05 9:12 ` Corentin Chary
@ 2012-05-20 13:09 ` Corentin Chary
2012-05-21 1:03 ` Zhang Rui
0 siblings, 1 reply; 9+ messages in thread
From: Corentin Chary @ 2012-05-20 13:09 UTC (permalink / raw)
To: Zhang, Rui, Len Brown
Cc: Pavel Machek, Dmitry Torokhov, linux acpi, Jonathan Cameron,
Amit Kucheria, Jean Delvare
On Mon, Mar 5, 2012 at 10:12 AM, Corentin Chary
<corentin.chary@gmail.com> wrote:
> On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
>>> I was looking at the DSDT of a new samsung laptop (I can send you the
>>> output of acpidump if interested), and it export a standard ACPI ALS
>>> device. So, it's actually great to see vendor using that, but it seems
>>> that the series adding support for that and sent back in 2009 is not
>>> available in the kernel. I'd really like to use my the ALS, what's the
>>> current status of the driver ? Still blocked because we don't have a
>>> generic sysfs class ? If yes, can't we just use a non-standard
>>> interface ? It would still be better than no driver at all.
>>
>> Yes, I think ACPI ALS support has been waiting for hardware to justify
>> its existence.
>>
>> When it first entered the spec, we were excited to see it was present
>> in some high-end laptops, but IIR on closer examination the AML turned
>> out to be dummy code.
>>
>> If you can verify that your Samsung really does implement ACPI ALS,
>> then that is all we need to stumble forward.
>>
>> thanks,
>> -Len Brown, Intel Open Source Technology Center
>
> Hello,
>
> As stated in my previous mails, the implementation on this laptop is
> perfectly functional, and since Windows 7 seems to be able to use
> ACPI ALS nativelly [1] I suspect new (high end ?) laptop will all
> support that.
> Is there any plan to revive this driver for 3.4 or 3.5 ? Should
> someone repost the last version of the previous patchset for
> discussion ?
> And no, on this laptop ALS is definitively not a gadget.
>
> Thanks,
>
> - http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx
Adding more people that were interested in the previous discussion.
What was the exact status of the als class ? Rui Zhang are you still
interested in this ?
Thanks,
--
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2012-05-20 13:09 ` Corentin Chary
@ 2012-05-21 1:03 ` Zhang Rui
2012-05-21 6:57 ` Corentin Chary
2012-05-21 8:07 ` Jonathan Cameron
0 siblings, 2 replies; 9+ messages in thread
From: Zhang Rui @ 2012-05-21 1:03 UTC (permalink / raw)
To: Corentin Chary
Cc: Len Brown, Pavel Machek, Dmitry Torokhov, linux acpi,
Jonathan Cameron, Amit Kucheria, Jean Delvare
On 日, 2012-05-20 at 15:09 +0200, Corentin Chary wrote:
> On Mon, Mar 5, 2012 at 10:12 AM, Corentin Chary
> <corentin.chary@gmail.com> wrote:
> > On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
> >>> I was looking at the DSDT of a new samsung laptop (I can send you the
> >>> output of acpidump if interested), and it export a standard ACPI ALS
> >>> device. So, it's actually great to see vendor using that, but it seems
> >>> that the series adding support for that and sent back in 2009 is not
> >>> available in the kernel. I'd really like to use my the ALS, what's the
> >>> current status of the driver ? Still blocked because we don't have a
> >>> generic sysfs class ? If yes, can't we just use a non-standard
> >>> interface ? It would still be better than no driver at all.
> >>
> >> Yes, I think ACPI ALS support has been waiting for hardware to justify
> >> its existence.
> >>
> >> When it first entered the spec, we were excited to see it was present
> >> in some high-end laptops, but IIR on closer examination the AML turned
> >> out to be dummy code.
> >>
> >> If you can verify that your Samsung really does implement ACPI ALS,
> >> then that is all we need to stumble forward.
> >>
> >> thanks,
> >> -Len Brown, Intel Open Source Technology Center
> >
> > Hello,
> >
> > As stated in my previous mails, the implementation on this laptop is
> > perfectly functional, and since Windows 7 seems to be able to use
> > ACPI ALS nativelly [1] I suspect new (high end ?) laptop will all
> > support that.
> > Is there any plan to revive this driver for 3.4 or 3.5 ? Should
> > someone repost the last version of the previous patchset for
> > discussion ?
> > And no, on this laptop ALS is definitively not a gadget.
> >
> > Thanks,
> >
> > - http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx
>
> Adding more people that were interested in the previous discussion.
> What was the exact status of the als class ? Rui Zhang are you still
> interested in this ?
> Thanks,
>
well, I need some time to get updated about this.
Say I'm not sure if we still want to introduce an ALS class or we need
to use drivers/staging/iio/ instead, today.
BTW, you own this laptop, right? Can you send me the model name of this
laptop and its acpidump output?
thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2012-05-21 1:03 ` Zhang Rui
@ 2012-05-21 6:57 ` Corentin Chary
2012-05-21 8:07 ` Jonathan Cameron
1 sibling, 0 replies; 9+ messages in thread
From: Corentin Chary @ 2012-05-21 6:57 UTC (permalink / raw)
To: Zhang Rui
Cc: Len Brown, Pavel Machek, Dmitry Torokhov, linux acpi,
Jonathan Cameron, Amit Kucheria, Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 2961 bytes --]
On Mon, May 21, 2012 at 3:03 AM, Zhang Rui <rui.zhang@intel.com> wrote:
> On 日, 2012-05-20 at 15:09 +0200, Corentin Chary wrote:
>> On Mon, Mar 5, 2012 at 10:12 AM, Corentin Chary
>> <corentin.chary@gmail.com> wrote:
>> > On Sun, Nov 6, 2011 at 11:16 PM, Len Brown <lenb@kernel.org> wrote:
>> >>> I was looking at the DSDT of a new samsung laptop (I can send you the
>> >>> output of acpidump if interested), and it export a standard ACPI ALS
>> >>> device. So, it's actually great to see vendor using that, but it seems
>> >>> that the series adding support for that and sent back in 2009 is not
>> >>> available in the kernel. I'd really like to use my the ALS, what's the
>> >>> current status of the driver ? Still blocked because we don't have a
>> >>> generic sysfs class ? If yes, can't we just use a non-standard
>> >>> interface ? It would still be better than no driver at all.
>> >>
>> >> Yes, I think ACPI ALS support has been waiting for hardware to justify
>> >> its existence.
>> >>
>> >> When it first entered the spec, we were excited to see it was present
>> >> in some high-end laptops, but IIR on closer examination the AML turned
>> >> out to be dummy code.
>> >>
>> >> If you can verify that your Samsung really does implement ACPI ALS,
>> >> then that is all we need to stumble forward.
>> >>
>> >> thanks,
>> >> -Len Brown, Intel Open Source Technology Center
>> >
>> > Hello,
>> >
>> > As stated in my previous mails, the implementation on this laptop is
>> > perfectly functional, and since Windows 7 seems to be able to use
>> > ACPI ALS nativelly [1] I suspect new (high end ?) laptop will all
>> > support that.
>> > Is there any plan to revive this driver for 3.4 or 3.5 ? Should
>> > someone repost the last version of the previous patchset for
>> > discussion ?
>> > And no, on this laptop ALS is definitively not a gadget.
>> >
>> > Thanks,
>> >
>> > - http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx
>>
>> Adding more people that were interested in the previous discussion.
>> What was the exact status of the als class ? Rui Zhang are you still
>> interested in this ?
>> Thanks,
>>
> well, I need some time to get updated about this.
> Say I'm not sure if we still want to introduce an ALS class or we need
> to use drivers/staging/iio/ instead, today.
As long as "display_adjustment" is still reported correctly...
> BTW, you own this laptop, right?
Yep
> Can you send me the model name of this
> laptop and its acpidump output?
Done, basically it's a "Samsung Series 9" but you will get more
informations from dmidecode. Note that as I said, windows 7 handle
ACPI ALS out the box
(http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx),
so expect more laptop in a short future.
Thanks !
--
Corentin Chary
http://xf.iksaif.net
[-- Attachment #2: acpidump.gz --]
[-- Type: application/x-gzip, Size: 53717 bytes --]
[-- Attachment #3: dmidecode.gz --]
[-- Type: application/x-gzip, Size: 4068 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ACPI ALS Status ?
2012-05-21 1:03 ` Zhang Rui
2012-05-21 6:57 ` Corentin Chary
@ 2012-05-21 8:07 ` Jonathan Cameron
1 sibling, 0 replies; 9+ messages in thread
From: Jonathan Cameron @ 2012-05-21 8:07 UTC (permalink / raw)
To: Zhang Rui
Cc: Corentin Chary, Len Brown, Pavel Machek, Dmitry Torokhov,
linux acpi, Amit Kucheria, Jean Delvare
On 5/21/2012 2:03 AM, Zhang Rui wrote:
> On 日, 2012-05-20 at 15:09 +0200, Corentin Chary wrote:
>> On Mon, Mar 5, 2012 at 10:12 AM, Corentin Chary
>> <corentin.chary@gmail.com> wrote:
>>> On Sun, Nov 6, 2011 at 11:16 PM, Len Brown<lenb@kernel.org> wrote:
>>>>> I was looking at the DSDT of a new samsung laptop (I can send you the
>>>>> output of acpidump if interested), and it export a standard ACPI ALS
>>>>> device. So, it's actually great to see vendor using that, but it seems
>>>>> that the series adding support for that and sent back in 2009 is not
>>>>> available in the kernel. I'd really like to use my the ALS, what's the
>>>>> current status of the driver ? Still blocked because we don't have a
>>>>> generic sysfs class ? If yes, can't we just use a non-standard
>>>>> interface ? It would still be better than no driver at all.
>>>>
>>>> Yes, I think ACPI ALS support has been waiting for hardware to justify
>>>> its existence.
>>>>
>>>> When it first entered the spec, we were excited to see it was present
>>>> in some high-end laptops, but IIR on closer examination the AML turned
>>>> out to be dummy code.
>>>>
>>>> If you can verify that your Samsung really does implement ACPI ALS,
>>>> then that is all we need to stumble forward.
>>>>
>>>> thanks,
>>>> -Len Brown, Intel Open Source Technology Center
>>>
>>> Hello,
>>>
>>> As stated in my previous mails, the implementation on this laptop is
>>> perfectly functional, and since Windows 7 seems to be able to use
>>> ACPI ALS nativelly [1] I suspect new (high end ?) laptop will all
>>> support that.
>>> Is there any plan to revive this driver for 3.4 or 3.5 ? Should
>>> someone repost the last version of the previous patchset for
>>> discussion ?
>>> And no, on this laptop ALS is definitively not a gadget.
>>>
>>> Thanks,
>>>
>>> - http://download.microsoft.com/download/3/0/2/3027D574-C433-412A-A8B6-5E0A75D5B237/ambient-light-sensors.docx
>>
>> Adding more people that were interested in the previous discussion.
>> What was the exact status of the als class ? Rui Zhang are you still
>> interested in this ?
>> Thanks,
>>
> well, I need some time to get updated about this.
> Say I'm not sure if we still want to introduce an ALS class or we need
> to use drivers/staging/iio/ instead, today.
Shortly the IIO core should (*fingers crossed*) move to drivers/iio/
It's queue up for the next merge window. driver/iio/light is probably
a suitable place for acpi light sensor drivers. Don't think we've moved
any of the light sensors out of staging yet, but it's just a question of
no one having had time to check them thoroughly rather than a
fundamental reason. At least one new sensor driver is targetting that
location but is still going through revisions..
ALS as a separate class died when Linus said he wouldn't pull it.
>
> BTW, you own this laptop, right? Can you send me the model name of this
> laptop and its acpidump output?
>
> thanks,
> rui
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-21 8:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-06 19:34 ACPI ALS Status ? Corentin Chary
2011-11-06 22:16 ` Len Brown
[not found] ` <CAHR064hprC29+4wso1nR8cL4ZDXEqj7CONF6h2cdyeuHxmkjiw@mail.gmail.com>
2011-12-03 9:43 ` Corentin Chary
2012-01-30 8:28 ` Corentin Chary
2012-03-05 9:12 ` Corentin Chary
2012-05-20 13:09 ` Corentin Chary
2012-05-21 1:03 ` Zhang Rui
2012-05-21 6:57 ` Corentin Chary
2012-05-21 8:07 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).