Re: [RFC PATCH V3 3/3] usb : Add sysfs files to control usb port's power

[Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On 2012年06月04日 23:02, Alan Stern wrote:
> On Mon, 4 Jun 2012, Lan Tianyu wrote:
> s/attribue/attribute/  -- here and below
>
>> +		allows the user space to control the power policy on the usb port
>> +
>> +		All ports have one of the following three values for portX/control
>> +		"auto" - For ports with device, if the device was not in the suspend
>> +			at that pointer, the power would remain on but it would power
>> +			off when it was suspended. If the the device was in the suspend,
>> +			"auto" means the device could be put into much lower state so
>> +			the device would be resumed and suspended again.
>
> The patch does not implement anything at all for "auto".  It should do
> _something_.
>
Yeah, if we don't power off port without device when echo "auto" > portX/control,
this patch does nothing about "auto". Original plan is to deal with port without
devices firstly. Do you mean I should add the process of port with device in this
patch?


-- 
Best Regards
Tianyu Lan
linux kernel enabling team
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html