* [PATCH] ACPI video: Still use ACPI backlight control if _DOS doesn't exist
@ 2012-06-20 1:48 Zhang Rui
2012-06-30 4:44 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Rui @ 2012-06-20 1:48 UTC (permalink / raw)
To: Len, Brown; +Cc: linux-acpi@vger.kernel.org
This is a regression introduced by commit
ea9f8856bd6d4ed45885b06a338f7362cd6c60e5
https://bugzilla.kernel.org/show_bug.cgi?id=43168
Some platforms don't have _DOS control method, but the ACPI
backlight still works.
We should not invoke _DOS for these platforms.
CC : Igor Murzov <intergalactic.anonymous@gmail.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
drivers/acpi/video.c | 2 ++
1 file changed, 2 insertions(+)
Index: rtd3/drivers/acpi/video.c
===================================================================
--- rtd3.orig/drivers/acpi/video.c
+++ rtd3/drivers/acpi/video.c
@@ -558,6 +558,8 @@ acpi_video_bus_DOS(struct acpi_video_bus
union acpi_object arg0 = { ACPI_TYPE_INTEGER };
struct acpi_object_list args = { 1, &arg0 };
+ if (!video->cap._DOS)
+ return 0;
if (bios_flag < 0 || bios_flag > 3 || lcd_flag < 0 || lcd_flag > 1)
return -EINVAL;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI video: Still use ACPI backlight control if _DOS doesn't exist
2012-06-20 1:48 [PATCH] ACPI video: Still use ACPI backlight control if _DOS doesn't exist Zhang Rui
@ 2012-06-30 4:44 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2012-06-30 4:44 UTC (permalink / raw)
To: Zhang Rui; +Cc: linux-acpi@vger.kernel.org
applied.
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-30 4:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-20 1:48 [PATCH] ACPI video: Still use ACPI backlight control if _DOS doesn't exist Zhang Rui
2012-06-30 4:44 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).