linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure
       [not found] <1342107003-9811-1-git-send-email-daniel.lezcano@linaro.org>
@ 2012-07-12 20:34 ` Rafael J. Wysocki
  2012-07-12 20:47   ` Daniel Lezcano
  0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2012-07-12 20:34 UTC (permalink / raw)
  To: Daniel Lezcano; +Cc: Linux PM list, ACPI Devel Mailing List

On Thursday, July 12, 2012, Daniel Lezcano wrote:
> Remove the latency_ticks field as it is not used.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Thanks for the patches, but can you please repost them to
linux-pm@vger.kernel.org so that they are included into the kernel.org
Patchwork?  They will be much easier to review and handle then.

And please CC linux-acpi@vger.kernel.org for all ACPI-related patches in the
future.

Thanks,
Rafael


> ---
>  drivers/acpi/processor_idle.c |    2 --
>  include/acpi/processor.h      |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b894627..9ef007d 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -583,7 +583,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
>  	 */
>  	cx->valid = 1;
>  
> -	cx->latency_ticks = cx->latency;
>  	/*
>  	 * On older chipsets, BM_RLD needs to be set
>  	 * in order for Bus Master activity to wake the
> @@ -616,7 +615,6 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
>  			if (!cx->address)
>  				break;
>  			cx->valid = 1; 
> -			cx->latency_ticks = cx->latency; /* Normalize latency */
>  			break;
>  
>  		case ACPI_STATE_C3:
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index ac3bff6..19423c3 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
>  	u8 entry_method;
>  	u8 index;
>  	u32 latency;
> -	u32 latency_ticks;
>  	u32 power;
>  	u32 usage;
>  	u64 time;
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure
  2012-07-12 20:34 ` [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure Rafael J. Wysocki
@ 2012-07-12 20:47   ` Daniel Lezcano
  0 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2012-07-12 20:47 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux PM list, ACPI Devel Mailing List

On 07/12/2012 10:34 PM, Rafael J. Wysocki wrote:
> On Thursday, July 12, 2012, Daniel Lezcano wrote:
>> Remove the latency_ticks field as it is not used.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> Thanks for the patches, but can you please repost them to
> linux-pm@vger.kernel.org so that they are included into the kernel.org
> Patchwork?  They will be much easier to review and handle then.
> 
> And please CC linux-acpi@vger.kernel.org for all ACPI-related patches in the
> future.

Yes, sure. Sorry for that.

Thanks
  -- Daniel

>> ---
>>  drivers/acpi/processor_idle.c |    2 --
>>  include/acpi/processor.h      |    1 -
>>  2 files changed, 0 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
>> index b894627..9ef007d 100644
>> --- a/drivers/acpi/processor_idle.c
>> +++ b/drivers/acpi/processor_idle.c
>> @@ -583,7 +583,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
>>  	 */
>>  	cx->valid = 1;
>>  
>> -	cx->latency_ticks = cx->latency;
>>  	/*
>>  	 * On older chipsets, BM_RLD needs to be set
>>  	 * in order for Bus Master activity to wake the
>> @@ -616,7 +615,6 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
>>  			if (!cx->address)
>>  				break;
>>  			cx->valid = 1; 
>> -			cx->latency_ticks = cx->latency; /* Normalize latency */
>>  			break;
>>  
>>  		case ACPI_STATE_C3:
>> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
>> index ac3bff6..19423c3 100644
>> --- a/include/acpi/processor.h
>> +++ b/include/acpi/processor.h
>> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
>>  	u8 entry_method;
>>  	u8 index;
>>  	u32 latency;
>> -	u32 latency_ticks;
>>  	u32 power;
>>  	u32 usage;
>>  	u64 time;
>>
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure
@ 2012-07-12 21:03 Daniel Lezcano
  2012-07-12 21:40 ` Rafael J. Wysocki
  2012-07-17 20:32 ` Rafael J. Wysocki
  0 siblings, 2 replies; 5+ messages in thread
From: Daniel Lezcano @ 2012-07-12 21:03 UTC (permalink / raw)
  To: rjw, lenb; +Cc: linux-pm, linux-acpi

Remove the latency_ticks field as it is not used.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/acpi/processor_idle.c |    2 --
 include/acpi/processor.h      |    1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
index f3decb3..da92c65 100644
--- a/drivers/acpi/processor_idle.c
+++ b/drivers/acpi/processor_idle.c
@@ -586,7 +586,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
 	 */
 	cx->valid = 1;
 
-	cx->latency_ticks = cx->latency;
 	/*
 	 * On older chipsets, BM_RLD needs to be set
 	 * in order for Bus Master activity to wake the
@@ -619,7 +618,6 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
 			if (!cx->address)
 				break;
 			cx->valid = 1; 
-			cx->latency_ticks = cx->latency; /* Normalize latency */
 			break;
 
 		case ACPI_STATE_C3:
diff --git a/include/acpi/processor.h b/include/acpi/processor.h
index 9d65047..a70cbcc 100644
--- a/include/acpi/processor.h
+++ b/include/acpi/processor.h
@@ -59,7 +59,6 @@ struct acpi_processor_cx {
 	u8 entry_method;
 	u8 index;
 	u32 latency;
-	u32 latency_ticks;
 	u32 power;
 	u32 usage;
 	u64 time;
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure
  2012-07-12 21:03 Daniel Lezcano
@ 2012-07-12 21:40 ` Rafael J. Wysocki
  2012-07-17 20:32 ` Rafael J. Wysocki
  1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2012-07-12 21:40 UTC (permalink / raw)
  To: Daniel Lezcano; +Cc: lenb, linux-pm, linux-acpi

On Thursday, July 12, 2012, Daniel Lezcano wrote:
> Remove the latency_ticks field as it is not used.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

This one looks good to me.

Thanks,
Rafael


> ---
>  drivers/acpi/processor_idle.c |    2 --
>  include/acpi/processor.h      |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f3decb3..da92c65 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -586,7 +586,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
>  	 */
>  	cx->valid = 1;
>  
> -	cx->latency_ticks = cx->latency;
>  	/*
>  	 * On older chipsets, BM_RLD needs to be set
>  	 * in order for Bus Master activity to wake the
> @@ -619,7 +618,6 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
>  			if (!cx->address)
>  				break;
>  			cx->valid = 1; 
> -			cx->latency_ticks = cx->latency; /* Normalize latency */
>  			break;
>  
>  		case ACPI_STATE_C3:
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 9d65047..a70cbcc 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
>  	u8 entry_method;
>  	u8 index;
>  	u32 latency;
> -	u32 latency_ticks;
>  	u32 power;
>  	u32 usage;
>  	u64 time;
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure
  2012-07-12 21:03 Daniel Lezcano
  2012-07-12 21:40 ` Rafael J. Wysocki
@ 2012-07-17 20:32 ` Rafael J. Wysocki
  1 sibling, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2012-07-17 20:32 UTC (permalink / raw)
  To: Daniel Lezcano; +Cc: lenb, linux-pm, linux-acpi

On Thursday, July 12, 2012, Daniel Lezcano wrote:
> Remove the latency_ticks field as it is not used.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>

Applied to the 'pm-cpuidle' branch of the linux-pm.git tree.

Thanks,
Rafael


> ---
>  drivers/acpi/processor_idle.c |    2 --
>  include/acpi/processor.h      |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f3decb3..da92c65 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -586,7 +586,6 @@ static void acpi_processor_power_verify_c3(struct acpi_processor *pr,
>  	 */
>  	cx->valid = 1;
>  
> -	cx->latency_ticks = cx->latency;
>  	/*
>  	 * On older chipsets, BM_RLD needs to be set
>  	 * in order for Bus Master activity to wake the
> @@ -619,7 +618,6 @@ static int acpi_processor_power_verify(struct acpi_processor *pr)
>  			if (!cx->address)
>  				break;
>  			cx->valid = 1; 
> -			cx->latency_ticks = cx->latency; /* Normalize latency */
>  			break;
>  
>  		case ACPI_STATE_C3:
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index 9d65047..a70cbcc 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -59,7 +59,6 @@ struct acpi_processor_cx {
>  	u8 entry_method;
>  	u8 index;
>  	u32 latency;
> -	u32 latency_ticks;
>  	u32 power;
>  	u32 usage;
>  	u64 time;
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-07-17 20:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1342107003-9811-1-git-send-email-daniel.lezcano@linaro.org>
2012-07-12 20:34 ` [PATCH 1/5] acpi : remove latency_ticks from acpi_processor_cx structure Rafael J. Wysocki
2012-07-12 20:47   ` Daniel Lezcano
2012-07-12 21:03 Daniel Lezcano
2012-07-12 21:40 ` Rafael J. Wysocki
2012-07-17 20:32 ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).