From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F1DB20C322; Wed, 6 Nov 2024 20:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730925881; cv=none; b=UTuJe8opnekSNhAViozhxg9xUlco26PMvm8uDOyc+h+5+8d9Lg77VhNQ8k5rTPCF8h7Hl9qBVjaakUQT6B8r0VNTNLdPHoH2jsP3IsgV4uDYHKSHYu9bvihpNBa+TwiF4VYti7SrQ2tGGfuWPQ5wrJzvNqntQN+1L3tmqPi8UVI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730925881; c=relaxed/simple; bh=q0JRBK+4x8auhFbRmkX2cxNPzWVh2GbjYYLjjrwiuYU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W7WpdqeiR/hYCW4k8H2mUlZT7TBCaL3P1JjHq8c0hGv4YfN/ohzv5OFyniRDN+NgQyuvw+gMarPo6wleFDpkAmrd9KXP3DideLoB03HhU0As+qxVK7ycy0MIFVfZsFbQuBzqnfQV7aC9Iqtj+khjQv2KYWejgXLABZMKsf+e55c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qqzD8Wxb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qqzD8Wxb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EAC9C4CEC6; Wed, 6 Nov 2024 20:44:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730925879; bh=q0JRBK+4x8auhFbRmkX2cxNPzWVh2GbjYYLjjrwiuYU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=qqzD8WxbX8IMLbOkK08c+D9/XWg6d87iApQrm0rPAV9e6VbZNDFO+DlwsgJtn9I+p fUlZNE+JAhVVLf6AQTVJe1y0TXeOKGYPEHBrTlYa+rA7XJ02yhKvqUv5apP7ESaknd hRL4Bt8ywgPOcoZD+0cKd8aRaBSqdNouAc4vCqFBhqV8vq5rx1OmK0/t36IzGwqgNS VqbWokLa0THMx2df8W1hXutrflpWTDS8r7DxLpxLyrO60W9oAWLMG9opZzob0KaWr9 GXBxw+U/CY80yO8y6sel7vRivZzxxZCzaTuLcmAB52l7dHf4rBPdaBjuUmzx3kMWDs W8oiqTXCMG1Ag== Message-ID: <4b2d9200-cee9-484c-87c1-39542ccce8a5@kernel.org> Date: Wed, 6 Nov 2024 14:44:36 -0600 Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] ACPI: processor: Move arch_init_invariance_cppc() call later To: "Rafael J. Wysocki" Cc: Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , Len Brown , Peter Zijlstra , Mario Limonciello , "Gautham R . Shenoy" , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "open list:ACPI" , Ivan Shapovalov , Oleksandr Natalenko References: <20241104222855.3959267-1-superm1@kernel.org> Content-Language: en-US From: Mario Limonciello In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/6/2024 14:33, Rafael J. Wysocki wrote: > On Tue, Nov 5, 2024 at 9:17 PM Rafael J. Wysocki wrote: >> >> On Mon, Nov 4, 2024 at 11:29 PM Mario Limonciello wrote: >>> >>> From: Mario Limonciello >>> >>> arch_init_invariance_cppc() is called at the end of >>> acpi_cppc_processor_probe() in order to configure frequency invariance >>> based upon the values from _CPC. >>> >>> This however doesn't work on AMD CPPC shared memory designs that have >>> AMD preferred cores enabled because _CPC needs to be analyzed from all >>> cores to judge if preferred cores are enabled. >>> >>> This issue manifests to users as a warning since commit 21fb59ab4b97 >>> ("ACPI: CPPC: Adjust debug messages in amd_set_max_freq_ratio() to warn"): >>> ``` >>> Could not retrieve highest performance (-19) >>> ``` >>> >>> However the warning isn't the cause of this, it was actually >>> commit 279f838a61f9 ("x86/amd: Detect preferred cores in >>> amd_get_boost_ratio_numerator()") which exposed the issue. >>> >>> To fix this problem, change arch_init_invariance_cppc() into a new weak >>> symbol that is called at the end of acpi_processor_driver_init(). >>> Each architecture that supports it can declare the symbol to override >>> the weak one. >> >> "Define it for x86, in arch/x86/kernel/acpi/cppc.c, and for all of the >> architectures using the generic arch_topology.c code." > > I've added this to the patch changelog and queued it up as a 6.12 fix. > > Thanks! Thanks!