From: Muhammad Usama Anjum <usama.anjum@collabora.com>
To: Guenter Roeck <groeck@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: usama.anjum@collabora.com,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Mark Gross" <markgross@kernel.org>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbo i Serra" <eballetbo@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Collabora Kernel ML" <kernel@collabora.com>,
"Guenter Roeck" <groeck@chromium.org>,
"Dmitry Torokhov" <dtor@chromium.org>,
"Gwendal Grignou" <gwendal@chromium.org>,
vbendeb@chromium.org, "Andy Shevchenko" <andy@infradead.org>,
"Ayman Bagabas" <ayman.bagabas@gmail.com>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Blaž Hrastnik" <blaz@mxxn.io>,
"Darren Hart" <dvhart@infradead.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Jeremy Soller" <jeremy@system76.com>,
"Mattias Jacobsson" <2pi@mok.nu>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Rajat Jain" <rajatja@google.com>,
"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH RESEND v11] platform/chrome: Add ChromeOS ACPI device driver
Date: Wed, 11 May 2022 21:29:46 +0500 [thread overview]
Message-ID: <4bcd4fd7-ff81-b480-6ad6-ae027e268c7e@collabora.com> (raw)
In-Reply-To: <CABXOdTe1N7iRTVrCZSgQo=dazofWByM_W6EZgWixLj=Z8Xg0ag@mail.gmail.com>
On 5/11/22 9:23 PM, Guenter Roeck wrote:
> On Wed, May 11, 2022 at 8:59 AM Muhammad Usama Anjum
> <usama.anjum@collabora.com> wrote:
>>>> +#define GPIO_ATTR_GROUP(_group, _name, _num) \
>>>> + static umode_t attr_is_visible_gpio_##_num(struct kobject *kobj, \
>>>> + struct attribute *attr, int n) \
>>>> + { \
>>>> + if (_num < chromeos_acpi_gpio_groups) \
>>>> + return attr->mode; \
>>>
>>>> + else \
>>>
>>> Redundant.
>> We are deciding on run time that how many GPIO attribute groups need to
>> be shown. chromeos_acpi_gpio_groups is set at run time. I don't see why
>> `else` can be redundant here.
>>
>
> else after return is _always_ unnecessary (and results in static
> analyzer messages).
>
Got it. I'll update. Thank you.
--
Muhammad Usama Anjum
next prev parent reply other threads:[~2022-05-11 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 6:44 [PATCH RESEND v11] platform/chrome: Add ChromeOS ACPI device driver Muhammad Usama Anjum
2022-05-10 9:33 ` Andy Shevchenko
2022-05-10 10:10 ` Greg Kroah-Hartman
2022-05-11 15:59 ` Muhammad Usama Anjum
2022-05-11 16:23 ` Guenter Roeck
2022-05-11 16:29 ` Muhammad Usama Anjum [this message]
2022-05-11 17:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bcd4fd7-ff81-b480-6ad6-ae027e268c7e@collabora.com \
--to=usama.anjum@collabora.com \
--cc=2pi@mok.nu \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=ayman.bagabas@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=blaz@mxxn.io \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@chromium.org \
--cc=dvhart@infradead.org \
--cc=eballetbo@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=gwendal@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jeremy@system76.com \
--cc=kernel@collabora.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rajatja@google.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=vbendeb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox