From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
Robert Moore <robert.moore@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
acpica-devel@lists.linux.dev, Aishwarya.TCV@arm.com
Subject: Re: [PATCH 2/5] ACPI: sysfs: use device lifecycle for _STR result
Date: Thu, 27 Jun 2024 19:17:09 +0200 [thread overview]
Message-ID: <4cd2352c-4e95-4ddf-a366-75dad45bf7e6@t-8ch.de> (raw)
In-Reply-To: <d599e864-9961-44e3-8b9b-bc41a8044319@sirena.org.uk>
Rafael:
Would you mind backing this series out for now?
I'll do some more experiments and resubmit.
On 2024-06-26 16:39:10+0000, Mark Brown wrote:
> On Tue, Jun 25, 2024 at 11:56:18PM +0200, Thomas Weißschuh wrote:
> > On 2024-06-25 21:57:13+0000, Mark Brown wrote:
>
> > > <2>[ 50.236703] acpi LNXTHERM:08: Resources present before probing
>
> > This does make sense, the device is not yet bound to a driver.
> > Which apparently precludes the usage of devres.
>
> Oh, yes - I really wouldn't expect that to work at all, devres is all
> about tying things to the device being bound so trying to use it outside
> of that is not something I'd expect to go well.
>
> > I'm also wondering why the _STR attribute behaved differently in the
> > first place.
> > Does the patch below work better?
>
> That patch applied on top of -next appears to resolve the issue.
Thanks for the confirmation
next prev parent reply other threads:[~2024-06-27 17:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 20:15 [PATCH 0/5] ACPI: sysfs: manage sysfs attributes through device core Thomas Weißschuh
2024-06-13 20:15 ` [PATCH 1/5] ACPI: sysfs: convert utf-16 from _STR to utf-8 only once Thomas Weißschuh
2024-06-17 18:37 ` Rafael J. Wysocki
2024-06-17 18:43 ` Rafael J. Wysocki
2024-06-17 18:57 ` Thomas Weißschuh
2024-06-17 19:20 ` Rafael J. Wysocki
2024-06-13 20:15 ` [PATCH 2/5] ACPI: sysfs: use device lifecycle for _STR result Thomas Weißschuh
2024-06-25 20:57 ` Mark Brown
2024-06-25 21:56 ` Thomas Weißschuh
2024-06-26 15:39 ` Mark Brown
2024-06-27 17:17 ` Thomas Weißschuh [this message]
2024-06-28 17:26 ` Rafael J. Wysocki
2024-06-13 20:15 ` [PATCH 3/5] ACPI: sysfs: manage attributes as attribute_group Thomas Weißschuh
2024-06-13 20:15 ` [PATCH 4/5] ACPI: sysfs: manage sysfs attributes through device core Thomas Weißschuh
2024-06-13 20:15 ` [PATCH 5/5] ACPI: sysfs: remove return value of acpi_device_setup_files() Thomas Weißschuh
2024-06-19 16:51 ` [PATCH 0/5] ACPI: sysfs: manage sysfs attributes through device core Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cd2352c-4e95-4ddf-a366-75dad45bf7e6@t-8ch.de \
--to=linux@weissschuh.net \
--cc=Aishwarya.TCV@arm.com \
--cc=acpica-devel@lists.linux.dev \
--cc=broonie@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox