From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95C6C04A6A for ; Mon, 7 Aug 2023 17:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231325AbjHGRG6 (ORCPT ); Mon, 7 Aug 2023 13:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjHGRG5 (ORCPT ); Mon, 7 Aug 2023 13:06:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18D111737 for ; Mon, 7 Aug 2023 10:06:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691427968; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+2bN+2QbGhq9h0FHi3A5aylDZ5TKWQyD8uS1jfBItL4=; b=IjWTKmeBkSjOgaG2p1Uo+FlNwkC4hEc83VPhTOOZpHtHY9X8JOEM3PCiGP3czWkscQp/um cMpPp+KsQ0zJ9BBT8owFWqPt8u8t5C03NKJugxk80RmkWJJ038IJgueAomzNmDL0yVwyyi ucvqsvK/U3mkM2wk1r0NHSayYCXVSws= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-_r34DjqDPla6bJjzTtOg6A-1; Mon, 07 Aug 2023 13:06:06 -0400 X-MC-Unique: _r34DjqDPla6bJjzTtOg6A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fe108cbed6so4754360e87.3 for ; Mon, 07 Aug 2023 10:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691427965; x=1692032765; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+2bN+2QbGhq9h0FHi3A5aylDZ5TKWQyD8uS1jfBItL4=; b=gnyf8l+XlHt9qs3D/3d5XGVf8BOqXSvYvSm8L9uot5DtFDWHWo7krsJD12uKAm7WZC RwAw/uKdzw6UMK0yKPa3C781ceqsQnVsRPChSKefNvxQ4qevGiRtZLHj0yWZ4Jp+wDLl NrSn1pX2vgQT66PKmZRxrhoC2m4liRlpBUVBIxF7jXLVXwSsSswDeRCD46S7vnJqZwDN QSFUqtSmXJ3g855PFIZlb+/qljekUCJ8Qp1RT8cc5mpjHhZzZKsx26IeTxwm40p/MGtm sTvuH05Knm7nAPJKnDb/jIlO09PxFFkNbz9A2co92l93jDU3xpdLIMB9/+S3C68ZrpVC 9oHw== X-Gm-Message-State: AOJu0YzgQ9mRFqHR+8vCqU9lg6Um1srAn957hFgz+uwdCZkN8nZHCEz2 cG4s7aCOVkS3tKIDv2XuvX5egIZHpjTn7dUC+8/3yPQgG7yGWIoqsPPW0K7a4D7hMQG5PtIuINA kWaHakYF+Qxa8cNmZZ8PZ2g== X-Received: by 2002:a2e:8217:0:b0:2b6:d89e:74e2 with SMTP id w23-20020a2e8217000000b002b6d89e74e2mr6992766ljg.7.1691427965187; Mon, 07 Aug 2023 10:06:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHT6vpsfSh0sALnDAZfqbKoc9EuWhKIUBNCSHBxjjTNtvISnhm4ewvF4pKaE0IzxDH4L2Oxvw== X-Received: by 2002:a2e:8217:0:b0:2b6:d89e:74e2 with SMTP id w23-20020a2e8217000000b002b6d89e74e2mr6992748ljg.7.1691427964796; Mon, 07 Aug 2023 10:06:04 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id f1-20020a17090624c100b0098de7d28c34sm5459701ejb.193.2023.08.07.10.06.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 10:06:04 -0700 (PDT) Message-ID: <4fae943f-6e72-3297-cc73-e1087e7a45bd@redhat.com> Date: Mon, 7 Aug 2023 19:06:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] ACPI: resource: revert "Remove "Zen" specific match and quirks" To: Mario Limonciello , "Rafael J . Wysocki" Cc: linux-acpi@vger.kernel.org, Linux regressions mailing list , stable@vger.kernel.org, August Wikerfors References: <20230806151453.10690-1-hdegoede@redhat.com> <130cb2e0-90b4-7d7b-1633-3469c859b30f@amd.com> <0c1cb09a-2e78-65ad-61c1-174e5226d08e@amd.com> <8f0cbe61-99aa-8c45-c29e-69c27ba96d81@redhat.com> <561f0807-a78c-4dab-b8ef-a0f0836902d9@amd.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <561f0807-a78c-4dab-b8ef-a0f0836902d9@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 8/7/23 13:39, Mario Limonciello wrote: >>> We haven't even given a try to fixing it; I think the revert is still hasty. >>> >>> I don't have a machine that can reproduce this failure, but I did confirm that my keyboard still works with this: >>> >>> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c >>> index 1dd8d5aebf678..b74d7d8cc8630 100644 >>> --- a/drivers/acpi/resource.c >>> +++ b/drivers/acpi/resource.c >>> @@ -19,7 +19,7 @@ >>>   #include >>> >>>   #ifdef CONFIG_X86 >>> -#define valid_IRQ(i) (((i) != 0) && ((i) != 2)) >>> +#define valid_IRQ(i) ((i) > 2) >>>   static inline bool acpi_iospace_resource_valid(struct resource *res) >>>   { >>>          /* On X86 IO space is limited to the [0 - 64K] IO port range */ >>> >>> Can we perhaps see if that works instead for some affected people? >> >> That does not just skip the override stuff, it will make the kernel return irqresource_disabled(res, 1) for the kbd IRQ: >> >> static inline void irqresource_disabled(struct resource *res, u32 irq) >> { >>          res->start = irq; >>          res->end = irq; >>          res->flags |= IORESOURCE_IRQ | IORESOURCE_DISABLED | IORESOURCE_UNSET; >> } >> >> Now not much code seems to actually check the IORESOURCE_DISABLED | IORESOURCE_UNSET flags, so this might still work but it does not seem like the right thing to do. >> > > Right; so it makes the resource get skipped when PNP is enumerated. Which AFAICT means that PNP enumerated i8042-s will not have any IRQ assigned at all and this will not work. Regards, Hans