From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiang Liu <jiang.liu@huawei.com>
Subject: Re: [RFC PATCH 1/3] ACPIHP: introduce a framework for ACPI based
 system device hotplug
Date: Thu, 2 Aug 2012 15:07:44 +0800
Message-ID: <501A2740.3000309@huawei.com>
References: <1343475772-21345-1-git-send-email-jiang.liu@huawei.com> <1343475772-21345-2-git-send-email-jiang.liu@huawei.com> <501A271A.5030808@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: QUOTED-PRINTABLE
Return-path: <linux-acpi-owner@vger.kernel.org>
Received: from szxga01-in.huawei.com ([119.145.14.64]:16483 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751486Ab2HBHJV (ORCPT
	<rfc822;linux-acpi@vger.kernel.org>); Thu, 2 Aug 2012 03:09:21 -0400
In-Reply-To: <501A271A.5030808@cn.fujitsu.com>
Sender: linux-acpi-owner@vger.kernel.org
List-Id: linux-acpi@vger.kernel.org
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: Jiang Liu <liuj97@gmail.com>, Len Brown <lenb@kernel.org>, Tony Luck <tony.luch@intel.com>, Bob Moore <robert.moore@intel.com>, Huang Ying <ying.huang@intel.com>, Yinghai Lu <yinghai@kernel.org>, Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>, Wen Congyang <wency@cn.fujitsu.com>, Taku Izumi <izumi.taku@jp.fujitsu.com>, Bjorn Helgaas <bhelgaas@google.com>, Hanjun Guo <guohanjun@huawei.com>, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Gaohuai Han <hangaohuai@huawei.com>

On 2012-8-2 15:07, Tang Chen wrote:
> Hi,
>=20
> A little problem here. :)
>=20
> On 07/28/2012 07:42 PM, Jiang Liu wrote:
>> +int acpihp_register_slot(struct acpihp_slot *slot)
>> +{
>> +	int ret;
>> +	char *name;
>> +	size_t off;
>> +
>> +	if (!slot || !slot->slot_ops)
>> +		return -EINVAL;
>> +
>> +	/* Hook top level hotplug slots under ACPI root device */
>> +	if (slot->parent)
>> +		slot->dev.parent =3D &slot->parent->dev;
>> +	else
>> +		slot->dev.parent =3D &acpi_root->dev;
>> +
>> +	ret =3D device_add(&slot->dev);
>> +	if (!ret) {
>> +		slot->flags |=3D ACPIHP_SLOT_FLAG_REGISTERED;
>> +		name =3D kmalloc(PAGE_SIZE, GFP_KERNEL);
>> +		if (name) {
>> +			off =3D acpihp_generate_link_name(slot, name, 0);
>> +			name[off - 1] =3D '\0';
>> +			sysfs_create_link(&acpihp_slot_kset->kobj,
>> +					  &slot->dev.kobj, name);
>=20
> I got a compiler warning here:
>   CC      drivers/acpi/hotplug/core.o
> drivers/acpi/hotplug/core.c: In function =91acpihp_register_slot=92:
> drivers/acpi/hotplug/core.c:199: warning: ignoring return value of =91=
sysfs_create_link=92, declared with attribute warn_unused_result
>=20
> Seems that we need to check the sysfs_create_link()'s return value he=
re, and if it fails,=20
> shall we at least give a warning message here ?
>=20
> Thanks. :)
Hi Tang,
	Thanks for your comments, will fix it in next version.
	Regards!
	Gerry

>=20
>=20
>> +			kfree(name);
>> +		}
>> +	}
>> +
>> +	return ret;
>> +}
>> +EXPORT_SYMBOL_GPL(acpihp_register_slot);
>=20


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" i=
n
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html