From: "Rafael J. Wysocki" <rafael@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Hans de Goede <hansg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Jeremy Soller <jeremy@system76.com>,
System76 Product Development <productdev@system76.com>
Subject: [PATCH v2 1/3] platform/x86: system76: Drop redundant devm_led_classdev_unregister()
Date: Wed, 18 Mar 2026 14:50:08 +0100 [thread overview]
Message-ID: <5057164.GXAFRqVoOG@rafael.j.wysocki> (raw)
In-Reply-To: <4721148.LvFx2qVVIh@rafael.j.wysocki>
From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Drop two redundant devm_led_classdev_unregister() calls from
system76_remove().
No intentional functional impact.
Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
v1 -> v2: New patch
---
drivers/platform/x86/system76_acpi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/platform/x86/system76_acpi.c b/drivers/platform/x86/system76_acpi.c
index 3da753b3d00d..d8b64e2c2713 100644
--- a/drivers/platform/x86/system76_acpi.c
+++ b/drivers/platform/x86/system76_acpi.c
@@ -800,9 +800,6 @@ static void system76_remove(struct acpi_device *acpi_dev)
kfree(data->ntmp);
}
- devm_led_classdev_unregister(&acpi_dev->dev, &data->ap_led);
- devm_led_classdev_unregister(&acpi_dev->dev, &data->kb_led);
-
system76_get(data, "FINI");
}
--
2.51.0
next prev parent reply other threads:[~2026-03-18 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-18 13:48 [PATCH v2 0/3] platform/x86: system76: Bind to a platform device instead of an ACPI one Rafael J. Wysocki
2026-03-18 13:50 ` Rafael J. Wysocki [this message]
2026-03-18 13:53 ` [PATCH v2 2/3] platform/x86: system76: Register ACPI notify handler directly Rafael J. Wysocki
2026-03-18 13:54 ` [PATCH v2 3/3] platform/x86: system76: Convert ACPI driver to a platform one Rafael J. Wysocki
2026-03-23 10:46 ` [PATCH v2 0/3] platform/x86: system76: Bind to a platform device instead of an ACPI one Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5057164.GXAFRqVoOG@rafael.j.wysocki \
--to=rafael@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jeremy@system76.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=productdev@system76.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox