From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiang Liu Subject: Re: [PATCH v3 0/6] acpi,pci: hostbridge hotplug support Date: Wed, 19 Sep 2012 08:50:41 +0800 Message-ID: <505916E1.7010300@huawei.com> References: <20120918151215.59ea763b.izumi.taku@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Yinghai Lu Cc: Taku Izumi , linux-pci@vger.kernel.org, bhelgaas@google.com, linux-acpi@vger.kernel.org, kaneshige.kenji@jp.fujitsu.com List-Id: linux-acpi@vger.kernel.org On 2012-9-19 2:41, Yinghai Lu wrote: > On Mon, Sep 17, 2012 at 11:12 PM, Taku Izumi wrote: >> Hi all, >> >> This patchset is 3rd version of the following: >> http://marc.info/?l=linux-pci&m=134457928913775&w=2 >> http://marc.info/?l=linux-pci&m=134665909321684&w=2 >> >> v2 -> v3: >> - change acpi_pci_drivers' add/remove interface according to Bjorn's suggestion >> - abandon RCU for protecting acpi_pci_roots list according to Bjorn's suggestion >> - change acpi_pci_find_root implementation to avoid potential deadlock >> >> * [PATCH v3 1/8] ACPI, PCI: Use normal list for struct acpi_pci_driver >> * [PATCH v3 2/8] ACPI, PCI: Notify acpi_pci_drivers when hot-plugging PCI root bridges >> * [PATCH v3 3/8] ACPI, PCI: add acpi_pci_drivers protection >> * [PATCH v3 4/8] ACPI, PCI: change acpi_pci_drivers' add/remove interface >> * [PATCH v3 5/8] ACPI, PCI: change acpi_pci_find_root implementation >> * [PATCH v3 6/8] ACPI, PCI: add acpi_pci_roots protection >> * [PATCH v3 7/8] ACPI, PCI: add hostbridge removal function >> * [PATCH v3 8/8] ACPI, PCI: add resoruce-assign code for devices under hot-added hostbridge > > now it is more similar to my for-pci-root-bus-hotplug-part4 and part5 > > http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=shortlog;h=refs/heads/for-pci-root-bus-hotplug-part5 > > big difference: > I separated code from acpiphp_glue.c to pci_root_hp.c for root bridge > hotplug support > > I thought we all agreed on that acpi root bridge hotplug plug need to > be separated from acpiphp at first. > > http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;h=ab9fd4ccbfb6120a4a4adf9833487d656b0501d3 > > and CONFIG_HOTPLUG will always be enabled, so root bridge hotplug will > be always enabled. > acpiphp will still be used as one module, and to keep it simple pciehp > will be used for pcie etc. > That make the system BIOS much simple to avoid acpiphp. I think it's a better way to separate host bridge hotplug functionality from acpiphp driver, so acpiphp only handles PCI device hotplug, which is much more clear. --Gerry