Re: [PATCH 4/4] cpuidle - support multiple drivers

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 09/30/2012 12:07 AM, Rafael J. Wysocki wrote:
> On Saturday, September 29, 2012, Daniel Lezcano wrote:
>> On 09/29/2012 11:41 AM, Francesco Lavra wrote:
>>> Hi,
>> Hi Francesco,
>>
>> thanks for reviewing the patch.
>>
>>>>  static ssize_t show_current_driver(struct device *dev,
>>>>  				   struct device_attribute *attr,
>>>>  				   char *buf)
>>>>  {
>>>> -	ssize_t ret;
>>>> -	struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();
>>>> +	struct cbarg cbarg = { .buf = buf };
>>> cbarg.count should be initialized to 0.
>> Actually, with this initialization, all the fields will be initialized
>> to 0, except 'buf'.
> However, it would be good to initialize count explicitly so as to show
> that we care about the initial value of it.

Ok, I will change that in a V2.

Rafael, you're right, this approach makes more sense IMO.

Thanks
-- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html