From: Len Brown <lenb@kernel.org>
To: Matthew Garrett <mjg@redhat.com>
Cc: Ondrej Zary <linux@rainbow-software.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [bisected] PS/2 keyboard and mouse dead on resume on Intel D845BG
Date: Tue, 09 Oct 2012 01:11:55 -0400 [thread overview]
Message-ID: <5073B21B.4090600@kernel.org> (raw)
In-Reply-To: <20121008144243.GC5068@srcf.ucam.org>
On 10/08/2012 10:42 AM, Matthew Garrett wrote:
> On Sun, Oct 07, 2012 at 09:00:09PM +0200, Ondrej Zary wrote:
>
>> Added acpi_read_bit_register there and it seems that SCI_EN is already set!
>>
>> This patch fixes the problem here. I wonder how this affects systems that
>> require SCI_EN to be set.
>
> I /think/ that this will be safe, but it doesn't match my recollection
> of how Windows behaves so it may break something. Any chance you can
> find someone with one of the machines mentioned in
> https://bugzilla.kernel.org/show_bug.cgi?id=13745 and make sure that
> they still work with your patch?
yikes.
we started with a white-list,
then we made setting SCI_EN the default,
and here is at least one box that wants to be on a black list
so that we don't set SCI_EN:-(
next prev parent reply other threads:[~2012-10-09 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 13:13 [bisected] PS/2 keyboard and mouse dead on resume on Intel D845BG Ondrej Zary
2012-10-07 19:00 ` Ondrej Zary
2012-10-07 19:59 ` Rafael J. Wysocki
2012-10-08 14:42 ` Matthew Garrett
2012-10-09 5:11 ` Len Brown [this message]
2012-10-09 6:17 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5073B21B.4090600@kernel.org \
--to=lenb@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=mjg@redhat.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).