cosmetic issue with error message 'Invalid Power Resource to register!'

cosmetic issue with error message 'Invalid Power Resource to register!'

[Toralf Förster]

From time to time I get a line like at my Gentoo Linux:

kernel: ACPI: Invalid Power Resource to register!<6>usb 2-1.2: new high-speed USB device number 3 using ehci_hcd

I'm wondering whether there should be newline between both of them or what <6> means.

-- 
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] acpi: add newline in power.c message

[Randy Dunlap]

From: Randy Dunlap <rdunlap@xenotime.net>

Add newline to printk so that the message is on a line
by itself and not merged with something unrelated to it.

Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Cc:	Len Brown <lenb@kernel.org>
Cc:	Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/acpi/power.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-37-rc3.orig/drivers/acpi/power.c
+++ lnx-37-rc3/drivers/acpi/power.c
@@ -473,7 +473,7 @@ int acpi_power_resource_register_device(
 	return ret;
 
 no_power_resource:
-	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
+	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
 	return -ENODEV;
 }
 EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] acpi: add newline in power.c message

[Bjorn Helgaas]

On Mon, Oct 29, 2012 at 11:25 AM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Add newline to printk so that the message is on a line
> by itself and not merged with something unrelated to it.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Reported-by: Toralf Förster <toralf.foerster@gmx.de>
> Cc:     Len Brown <lenb@kernel.org>
> Cc:     Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  drivers/acpi/power.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-37-rc3.orig/drivers/acpi/power.c
> +++ lnx-37-rc3/drivers/acpi/power.c
> @@ -473,7 +473,7 @@ int acpi_power_resource_register_device(
>         return ret;
>
>  no_power_resource:
> -       printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> +       printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");

It'd be nice if this and the other similar printks in this file
included a hint about the context, e.g., the device to which it's
related.

>         return -ENODEV;
>  }
>  EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] acpi: add newline in power.c message

[Rafael J. Wysocki]

On Monday, October 29, 2012 10:25:19 AM Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
> 
> Add newline to printk so that the message is on a line
> by itself and not merged with something unrelated to it.
> 
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Reported-by: Toralf Förster <toralf.foerster@gmx.de>
> Cc:	Len Brown <lenb@kernel.org>
> Cc:	Rafael J. Wysocki <rjw@sisk.pl>

Applied to the linux-next branch of the linux-pm.git tree as v3.8 material.

Thanks,
Rafael



> ---
>  drivers/acpi/power.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- lnx-37-rc3.orig/drivers/acpi/power.c
> +++ lnx-37-rc3/drivers/acpi/power.c
> @@ -473,7 +473,7 @@ int acpi_power_resource_register_device(
>  	return ret;
>  
>  no_power_resource:
> -	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!");
> +	printk(KERN_DEBUG PREFIX "Invalid Power Resource to register!\n");
>  	return -ENODEV;
>  }
>  EXPORT_SYMBOL_GPL(acpi_power_resource_register_device);
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html