Re: acpi_memhotplug.c: don't allow to eject the memory device if it is being used

[Wen Congyang <wency@cn.fujitsu.com>]

At 11/08/2012 05:58 PM, Rafael J. Wysocki Wrote:
> On Thursday, November 08, 2012 05:33:43 PM Wen Congyang wrote:
>> Hi, Rafael J. Wysocki 
>>
>> At 11/06/2012 10:05 PM, Dan Carpenter Wrote:
>>> On Tue, Nov 06, 2012 at 10:10:11AM +0800, Wen Congyang wrote:
>>>> At 11/06/2012 02:11 AM, Dan Carpenter Wrote:
>>>>> Hello Wen Congyang,
>>>>>
>>>>> The patch 306859f13dc1: "acpi_memhotplug.c: don't allow to eject the
>>>>> memory device if it is being used" from Nov 3, 2012, leads to the
>>>>> following Smatch warning:
>>>>> drivers/acpi/acpi_memhotplug.c:367 acpi_memory_remove_memory()
>>>>> 	 warn: inconsistent returns mutex:&mem_device->list_lock:
>>>>> 	locked (357,361) unlocked (367)
>>>>
>>>> Thanks for pointing it out.
>>>>
>>>> The patch 306859f13dc1 is in akpm's tree, and it conflicts with another
>>>> patch in linux-pm's tree. So Andrew Morton drops them.
>>>>
>>>> I will resend them based on linux-pm's next tree.
>>>
>>> Ok. Today's linux-next version 85fcb3758c10e "ACPI / memory-hotplug:
>>> introduce a mutex lock to protect the list in acpi_memory_device"
>>> has a similar problem and should be fixed as well.
>>
>> This patch is in pm tree, and there is one problem. Should I resend them?
> 
> Yes, please.
> 
> Please also let me know which commits in linux-pm.git/linux-next should be
> replaced with the new versions.

OK. I will write it in the patches.

Thanks
Wen Congyang

> 
> Thanks,
> Rafael
> 
>