From: "H. Peter Anvin" <hpa@zytor.com>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Enable A20 using KBC for some MSI laptops to fix S3 resume
Date: Tue, 11 Dec 2012 12:36:46 -0800 [thread overview]
Message-ID: <50C7995E.7060301@zytor.com> (raw)
In-Reply-To: <201212112129.13248.linux@rainbow-software.org>
On 12/11/2012 12:29 PM, Ondrej Zary wrote:
>
> Something like this? (It works.)
>
Something like that. We need to make sure we send the proper sequence,
though, or it might break some SMM firmware...
> diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h
> index d6cc77a..0807ac7 100644
> --- a/drivers/input/serio/i8042-x86ia64io.h
> +++ b/drivers/input/serio/i8042-x86ia64io.h
> @@ -921,6 +921,7 @@ static int __init i8042_platform_init(void)
> int retval;
>
> #ifdef CONFIG_X86
> + u8 a20_on = 0xdf;
> /* Just return if pre-detection shows no i8042 controller exist */
> if (!x86_platform.i8042_detect())
> return -ENODEV;
> @@ -960,6 +961,13 @@ static int __init i8042_platform_init(void)
>
> if (dmi_check_system(i8042_dmi_dritek_table))
> i8042_dritek = true;
> +
> + /*
> + * A20 was already enabled during early kernel init. But some buggy
> + * BIOSes (in MSI Laptops) require A20 to be enabled using 8042 to
> + * resume from S3. So we do it here and hope that nothing breaks.
> + */
> + i8042_command(&a20_on, 0x10d1);
> #endif /* CONFIG_X86 */
>
> return retval;
>
next prev parent reply other threads:[~2012-12-11 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 8:56 [PATCH v3] Enable A20 using KBC for some MSI laptops to fix S3 resume Ondrej Zary
2012-11-05 20:35 ` Ondrej Zary
2012-12-10 21:26 ` H. Peter Anvin
2012-12-10 22:51 ` Ondrej Zary
2012-12-11 18:59 ` Ondrej Zary
2012-12-11 19:07 ` H. Peter Anvin
2012-12-11 20:29 ` Ondrej Zary
2012-12-11 20:36 ` H. Peter Anvin [this message]
2012-12-11 20:50 ` Ondrej Zary
2012-12-11 20:56 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50C7995E.7060301@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).