Re: [PATCH v2 1/4] acpi: move x86/mm/srat.c to x86/kernel/acpi/srat.c

li guang
2013-02-05T05:45:02Z

在 2013-02-04一的 21:35 -0800，David Rientjes写道：
> On Tue, 5 Feb 2013, liguang wrote:
>
> > srat table should present only on acpi domain,
> > seems mm/ is not the right place for it.
> >
> > Reviewed-by: David Rientjes <rientjes@google.com>
>
> I certainly didn't review this, please read
> Documentation/SubmittingPatches.
>
> > Signed-off-by: liguang <lig.fnst@cn.fujitsu.com>
>
> Couple of issues with this:
>
> - it doesn't include your followup change "acpi: change Makefile for
> srat.c building" which is required for this to build, please fold it in
> and repost,
>
> - there is whitespace damage, we use tabs for indentation in Makefiles,
>
> - you're basing your patches on Linus' tree when arch/x86/mm/srat has
> changed in linux-next (15 insertions(+), 14 deletions(-)), please
> rebase this on the linux-next tree at git.kernel.org.
>
> Otherwise, looks good.

OK, I'll rebase on linux-next.
Thanks!