From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [Resend][PATCH] ACPI / glue: Drop .find_bridge() callback from struct acpi_bus_type Date: Thu, 28 Feb 2013 08:23:54 +0800 Message-ID: <512EA39A.7080205@intel.com> References: <2612891.I2roH54cPk@vostro.rjw.lan> <20130227222032.GA28616@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Yinghai Lu Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , ACPI Devel Maling List , LKML , Bjorn Helgaas , linux-usb@vger.kernel.org, Tejun Heo , linux-ide@vger.kernel.org, Jeff Garzik List-Id: linux-acpi@vger.kernel.org On 2013=E5=B9=B402=E6=9C=8828=E6=97=A5 07:31, Yinghai Lu wrote: > On Wed, Feb 27, 2013 at 2:20 PM, Greg Kroah-Hartman > wrote: >> On Wed, Feb 27, 2013 at 11:06:52PM +0100, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> After PCI has stopped using the .find_bridge() callback in >>> struct acpi_bus_type, the only remaining users of it are SATA and >>> USB. However, SATA only pretends to be a user, because it points >>> that callback to a stub always returning -ENODEV, and USB uses it >>> incorrectly, because as a result of the way it is used by USB every >>> device in the system that doesn't have a bus type or parent is >>> passed to usb_acpi_find_device() for inspection. >>> >>> What USB actually needs, though, is to call usb_acpi_find_device() >>> for USB ports that don't have a bus type defined, but have >>> usb_port_device_type as their device type. >> >> Ick, that's not good. Can you have the original creator of that cod= e >> (someone else from Intel, I can't remember at the moment), fix that = up >> properly and send me patches? >=20 > [Add To: Lan Tianyu ] Ok. I will fix it later. >=20 >> >>> Please let me know if there are any objections. >=20 > I still prefer to ask USB to add bus_type instead at first. >=20 > Thanks >=20 > Yinghai >=20 --=20 Best regards Tianyu Lan