From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped Date: Thu, 07 Mar 2013 22:09:26 -0800 Message-ID: <51398096.1060304@zytor.com> References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-2-git-send-email-yinghai@kernel.org> <20130308051059.GC14556@mtj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from terminus.zytor.com ([198.137.202.10]:35829 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750744Ab3CHGNO (ORCPT ); Fri, 8 Mar 2013 01:13:14 -0500 In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Tejun Heo Cc: Yinghai Lu , Thomas Gleixner , Ingo Molnar , Andrew Morton , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , David Airlie , Jacob Shin , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org On 03/07/2013 09:28 PM, Tejun Heo wrote: > On Thu, Mar 7, 2013 at 9:27 PM, Yinghai Lu wrote: >> They are not using memblock_find_in_range(), so 1ULL<< will not help. >> >> Really hope i915 drm guys could clean that hacks. > > The code isn't being used. Just leave it alone. Maybe add a comment. > The change is just making things more confusing. > Indeed, but... Daniel: can you guys clean this up or can we just remove the #if 0 clause? -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.