From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Brandewie Subject: Re: [PATCH] intel-pstate: Use #defines instead of hard-coded values. Date: Wed, 20 Mar 2013 09:11:09 -0700 Message-ID: <5149DF9D.20605@intel.com> References: <1363789270-29579-1-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-da0-f53.google.com ([209.85.210.53]:39327 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975Ab3CTQLO (ORCPT ); Wed, 20 Mar 2013 12:11:14 -0400 In-Reply-To: <1363789270-29579-1-git-send-email-konrad.wilk@oracle.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, rafael.j.wysocki@intel.com, dirk.j.brandewie@intel.com On 03/20/2013 07:21 AM, Konrad Rzeszutek Wilk wrote: > They are defined in coreboot (MSR_PLATFORM) and the other > one is already defined in msr-index.h. > > Lets use those. > > CC: rafael.j.wysocki@intel.com > CC: dirk.j.brandewie@intel.com > Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Dirk Brandewie > --- > arch/x86/include/uapi/asm/msr-index.h | 1 + > drivers/cpufreq/intel_pstate.c | 6 +++--- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/include/uapi/asm/msr-index.h b/arch/x86/include/uapi/asm/msr-index.h > index 892ce40..7a060f4 100644 > --- a/arch/x86/include/uapi/asm/msr-index.h > +++ b/arch/x86/include/uapi/asm/msr-index.h > @@ -44,6 +44,7 @@ > #define SNB_C1_AUTO_UNDEMOTE (1UL << 27) > #define SNB_C3_AUTO_UNDEMOTE (1UL << 28) > > +#define MSR_PLATFORM_INFO 0x000000ce > #define MSR_MTRRcap 0x000000fe > #define MSR_IA32_BBL_CR_CTL 0x00000119 > #define MSR_IA32_BBL_CR_CTL3 0x0000011e > diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c > index f6dd1e7..dadc27d 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -358,14 +358,14 @@ static void intel_pstate_sysfs_expose_params(void) > static int intel_pstate_min_pstate(void) > { > u64 value; > - rdmsrl(0xCE, value); > + rdmsrl(MSR_PLATFORM_INFO, value); > return (value >> 40) & 0xFF; > } > > static int intel_pstate_max_pstate(void) > { > u64 value; > - rdmsrl(0xCE, value); > + rdmsrl(MSR_PLATFORM_INFO, value); > return (value >> 8) & 0xFF; > } > > @@ -373,7 +373,7 @@ static int intel_pstate_turbo_pstate(void) > { > u64 value; > int nont, ret; > - rdmsrl(0x1AD, value); > + rdmsrl(MSR_NHM_TURBO_RATIO_LIMIT, value); > nont = intel_pstate_max_pstate(); > ret = ((value) & 255); > if (ret <= nont) >