From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Toshi Kani <toshi.kani@hp.com>, rjw@sisk.pl
Cc: linux-acpi@vger.kernel.org, tangchen@cn.fujitsu.com,
wency@cn.fujitsu.com, laijs@cn.fujitsu.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit
Date: Thu, 21 Mar 2013 13:39:15 +0900 [thread overview]
Message-ID: <514A8EF3.90203@jp.fujitsu.com> (raw)
In-Reply-To: <514A8E3C.1050902@jp.fujitsu.com>
acpi_memory_info has enabled bit and failed bit for controlling memory
hotplug. But we don't need to keep both bits.
The patch removes acpi_memory_info->failed bit.
Signed-off-by: yasuaki ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
v2 : Changed a based kernel from linux-3.9-rc2 to linux-pm.git/bleeding-edge.
---
drivers/acpi/acpi_memhotplug.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index ea78988..597cd65 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -73,7 +73,6 @@ struct acpi_memory_info {
unsigned short caching; /* memory cache attribute */
unsigned short write_protect; /* memory read/write attribute */
unsigned int enabled:1;
- unsigned int failed:1;
};
struct acpi_memory_device {
@@ -201,10 +200,8 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
* returns -EEXIST. If add_memory() returns the other error, it
* means that this memory block is not used by the kernel.
*/
- if (result && result != -EEXIST) {
- info->failed = 1;
+ if (result && result != -EEXIST)
continue;
- }
info->enabled = 1;
@@ -238,15 +235,7 @@ static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
nid = acpi_get_node(mem_device->device->handle);
list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
- if (info->failed)
- /* The kernel does not use this memory block */
- continue;
-
if (!info->enabled)
- /*
- * The kernel uses this memory block, but it may be not
- * managed by us.
- */
return -EBUSY;
if (nid < 0)
next prev parent reply other threads:[~2013-03-21 4:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 6:54 [Bug fix PATCH] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
2013-03-13 14:50 ` Toshi Kani
2013-03-18 2:19 ` [PATCH] Remove acpi_memory_info->failed bit Yasuaki Ishimatsu
2013-03-19 15:03 ` Toshi Kani
2013-03-20 23:57 ` Yasuaki Ishimatsu
2013-03-21 4:36 ` [Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
2013-03-21 4:39 ` Yasuaki Ishimatsu [this message]
2013-03-21 4:45 ` [PATCH 2/2] ACPI,acpi_memhotplug: Remove acpi_memory_info->failed bit Yasuaki Ishimatsu
2013-03-22 0:29 ` Toshi Kani
2013-03-22 1:35 ` Yasuaki Ishimatsu
2013-03-22 1:53 ` [PATCH v3 " Yasuaki Ishimatsu
2013-03-22 20:24 ` Toshi Kani
2013-03-25 23:57 ` Yasuaki Ishimatsu
2013-03-26 13:41 ` Rafael J. Wysocki
2013-03-27 23:58 ` Yasuaki Ishimatsu
2013-04-01 23:48 ` Rafael J. Wysocki
2013-04-02 0:12 ` Yasuaki Ishimatsu
2013-04-02 12:57 ` Rafael J. Wysocki
2013-04-02 23:55 ` Yasuaki Ishimatsu
2013-03-21 4:44 ` [Bug fix PATCH v2 1/2] ACPI,acpi_memhotplug: enable acpi_memory_info->enabled of memory device presented at boot-time Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=514A8EF3.90203@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tangchen@cn.fujitsu.com \
--cc=toshi.kani@hp.com \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox