Re: [PATCH v9 09/16] PCI, x86: implement pcibios_{add|remove}_bus() hooks

[Jiang Liu <liuj97@gmail.com>]

On 04/17/2013 04:27 AM, David Rientjes wrote:
> On Fri, 12 Apr 2013, Jiang Liu wrote:
> 
>> diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c
>> index 901177d..305c68b 100644
>> --- a/arch/x86/pci/common.c
>> +++ b/arch/x86/pci/common.c
>> @@ -6,6 +6,7 @@
>>  
>>  #include <linux/sched.h>
>>  #include <linux/pci.h>
>> +#include <linux/pci-acpi.h>
>>  #include <linux/ioport.h>
>>  #include <linux/init.h>
>>  #include <linux/dmi.h>
>> @@ -170,6 +171,16 @@ void pcibios_fixup_bus(struct pci_bus *b)
>>  		pcibios_fixup_device_resources(dev);
>>  }
>>  
>> +void pcibios_add_bus(struct pci_bus *bus)
>> +{
>> +	acpi_pci_add_bus(bus);
>> +}
>> +
>> +void pcibios_remove_bus(struct pci_bus *bus)
>> +{
>> +	acpi_pci_remove_bus(bus);
>> +}
>> +
>>  /*
>>   * Only use DMI information to set this if nothing was passed
>>   * on the kernel command line (which was parsed earlier).
> 
> This causes build errors when CONFIG_ACPI isn't enabled since both 
> acpi_pci_{add,remove}_bus() aren't defined in such a configuration:
> 
> arch/x86/pci/common.c: In function 'pcibios_add_bus':
> arch/x86/pci/common.c:176:2: error: implicit declaration of function 'acpi_pci_add_bus'
> arch/x86/pci/common.c: In function 'pcibios_remove_bus':
> arch/x86/pci/common.c:181:2: error: implicit declaration of function 'acpi_pci_remove_bus'
> 
Hi David,
	Thanks for report, I have sent a patch to Bjorn to fix this issue,
and it should have been fixed in Bjorn's git tree.
	Regards!
	Gerry