linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Len Brown <lenb@kernel.org>,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>, Micael Dias <kam1kaz3@gmail.com>,
	Dan Garton <dan.garton@gmail.com>,
	Bob Ziuchkovski <bob.ziuchkovski@gmail.com>
Subject: [PATCH] acpi: video: no automatic brightness changes by firmware
Date: Mon, 17 Jun 2013 09:01:10 +0800	[thread overview]
Message-ID: <51BE5FD6.6070405@intel.com> (raw)
In-Reply-To: <51B98CFD.7090409@intel.com>

Starting from win8, MS backlight control driver will set bit 2 of the
parameter of control method _DOS, to inform firmware it should not
perform any automatic brightness changes. This mostly affects hotkey
notification deliver - if we do not set this bit, on hotkey press,
firmware may choose to adjust brightness level instead of sending out
notification and doing nothing.

So this patch sets bit 2 when calling _DOS so that GUIs can show the
notification window on hotkey press.

The MS document on win8 backlight control is here:
http://msdn.microsoft.com/en-US/library/windows/hardware/jj159305

This patch solves problem for ASUS N56VZ and ASUS N56VJ, both for
notification delivery and for brightness control.

Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=52951
Buglink: https://bugzilla.kernel.org/show_bug.cgi?id=56711
Reported-and-tested-by: Micael Dias <kam1kaz3@gmail.com>
Reported-and-tested-by: Dan Garton <dan.garton@gmail.com>
Reported-and-tested-by: Bob Ziuchkovski <bob.ziuchkovski@gmail.com>
Signed-off-by: Aaron Lu <aaron.lu@intel.com>
---
 drivers/acpi/video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
index b8299f2..f8fa541 100644
--- a/drivers/acpi/video.c
+++ b/drivers/acpi/video.c
@@ -1543,12 +1543,12 @@ static int acpi_video_bus_put_devices(struct acpi_video_bus *video)
 
 static int acpi_video_bus_start_devices(struct acpi_video_bus *video)
 {
-	return acpi_video_bus_DOS(video, 0, 0);
+	return acpi_video_bus_DOS(video, 0, 1);
 }
 
 static int acpi_video_bus_stop_devices(struct acpi_video_bus *video)
 {
-	return acpi_video_bus_DOS(video, 0, 1);
+	return acpi_video_bus_DOS(video, 0, 0);
 }
 
 static void acpi_video_bus_notify(struct acpi_device *device, u32 event)
-- 
1.8.3.3.gfada522

       reply	other threads:[~2013-06-17  1:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51B98CFD.7090409@intel.com>
2013-06-17  1:01 ` Aaron Lu [this message]
2013-06-17 11:27   ` [PATCH] acpi: video: no automatic brightness changes by firmware Rafael J. Wysocki
2013-06-17 15:01     ` Aaron Lu
2013-06-17 22:19       ` Rafael J. Wysocki
2013-06-17 22:40   ` Matthew Garrett
2013-06-18  0:13     ` Aaron Lu
2013-07-05  1:15       ` Aaron Lu
2013-07-16  5:08         ` Aaron Lu
     [not found]           ` <CAKw44fYBePZ-Qy5VsUUyJ5ob5SA34LNNCmBtqyCz5D_hCbYgUQ@mail.gmail.com>
2013-07-17  6:27             ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BE5FD6.6070405@intel.com \
    --to=aaron.lu@intel.com \
    --cc=bob.ziuchkovski@gmail.com \
    --cc=dan.garton@gmail.com \
    --cc=kam1kaz3@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).