From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "ananth@in.ibm.com" <ananth@in.ibm.com>,
masbock@linux.vnet.ibm.com, lcm@linux.vnet.ibm.com,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
ying.huang@intel.com
Subject: Re: [PATCH] Re: [Patch] MCE, APEI: Don't enable CMCI when Firmware First mode is set in
Date: Mon, 17 Jun 2013 16:01:43 +0530 [thread overview]
Message-ID: <51BEE58F.5050204@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130617082135.GB7203@pd.tnic>
On 06/17/2013 01:51 PM, Borislav Petkov wrote:
> On Mon, Jun 17, 2013 at 01:41:03PM +0530, Naveen N. Rao wrote:
>> Yes, we used to poll since we do not get notified via MCE/CMCI.
>> However, with firmware first set in CMC structure, the firmware is
>> now controlling all corrected error reporting for these banks. So, we
>> should not be looking at these MCA banks at all.
>
> Ok,
>
> then the bank polling disabling part should be generic code (i.e., not
> in mce_intel) since it is part of the APEI crap. The CMCI disabling
> should be Intel-specific only as AMD has a similar mechanism which we'll
> need to disable at some point too.
Ok, I'll move mce_disable_bank() to mce.c and re-structure the patch
around that.
Thanks,
Naveen
next prev parent reply other threads:[~2013-06-17 10:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 22:58 [Patch] MCE, APEI: Don't enable CMCI when Firmware First mode is set in HEST for corrected machine checks Max Asbock
2013-05-06 23:25 ` Borislav Petkov
2013-05-07 3:32 ` Max Asbock
2013-05-07 13:19 ` Borislav Petkov
2013-05-07 15:40 ` Max Asbock
2013-05-07 18:51 ` Borislav Petkov
2013-05-07 21:34 ` Luck, Tony
2013-05-07 21:55 ` Borislav Petkov
2013-05-08 21:22 ` Borislav Petkov
2013-05-08 21:55 ` Luck, Tony
2013-05-08 22:15 ` Borislav Petkov
2013-05-08 22:22 ` Luck, Tony
2013-05-10 17:59 ` Max Asbock
2013-05-12 14:47 ` Borislav Petkov
2013-06-14 18:17 ` [PATCH] Re: [Patch] MCE, APEI: Don't enable CMCI when Firmware First mode is set in Naveen N. Rao
2013-06-15 14:48 ` Borislav Petkov
2013-06-17 7:00 ` Naveen N. Rao
2013-06-17 7:06 ` Borislav Petkov
2013-06-17 8:11 ` Naveen N. Rao
2013-06-17 8:21 ` Borislav Petkov
2013-06-17 10:31 ` Naveen N. Rao [this message]
2013-06-18 6:43 ` Naveen N. Rao
2013-06-18 22:29 ` Tony Luck
2013-06-19 6:58 ` Naveen N. Rao
2013-06-16 12:20 ` Borislav Petkov
2013-06-17 7:00 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BEE58F.5050204@linux.vnet.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=bp@alien8.de \
--cc=lcm@linux.vnet.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@linux.vnet.ibm.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).