linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>,
	Zhang Rui <rui.zhang@intel.com>, Micael Dias <kam1kaz3@gmail.com>,
	Dan Garton <dan.garton@gmail.com>,
	Bob Ziuchkovski <bob.ziuchkovski@gmail.com>
Subject: Re: [PATCH] acpi: video: no automatic brightness changes by firmware
Date: Tue, 18 Jun 2013 08:13:28 +0800	[thread overview]
Message-ID: <51BFA628.8000804@intel.com> (raw)
In-Reply-To: <20130617224040.GB14793@srcf.ucam.org>

On 06/18/2013 06:40 AM, Matthew Garrett wrote:
> On Mon, Jun 17, 2013 at 09:01:10AM +0800, Aaron Lu wrote:
>> Starting from win8, MS backlight control driver will set bit 2 of the
>> parameter of control method _DOS, to inform firmware it should not
>> perform any automatic brightness changes. This mostly affects hotkey
>> notification deliver - if we do not set this bit, on hotkey press,
>> firmware may choose to adjust brightness level instead of sending out
>> notification and doing nothing.
> 
> It's worth noting that this is a change in behaviour, and there's at 
> least one VIA-based netbook where making this change breaks backlight 
> control.

Thanks for pointing this out.
Do you have any more information about this system, like its ACPI dump?

BTW, perhaps we should make this behavior change only for win8 systems?

Thanks,
Aaron

  reply	other threads:[~2013-06-18  0:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <51B98CFD.7090409@intel.com>
2013-06-17  1:01 ` [PATCH] acpi: video: no automatic brightness changes by firmware Aaron Lu
2013-06-17 11:27   ` Rafael J. Wysocki
2013-06-17 15:01     ` Aaron Lu
2013-06-17 22:19       ` Rafael J. Wysocki
2013-06-17 22:40   ` Matthew Garrett
2013-06-18  0:13     ` Aaron Lu [this message]
2013-07-05  1:15       ` Aaron Lu
2013-07-16  5:08         ` Aaron Lu
     [not found]           ` <CAKw44fYBePZ-Qy5VsUUyJ5ob5SA34LNNCmBtqyCz5D_hCbYgUQ@mail.gmail.com>
2013-07-17  6:27             ` Aaron Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51BFA628.8000804@intel.com \
    --to=aaron.lu@intel.com \
    --cc=bob.ziuchkovski@gmail.com \
    --cc=dan.garton@gmail.com \
    --cc=kam1kaz3@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).