From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lan Tianyu Subject: Re: [PATCH 2/2] CPUFreq: Add new sysfs attribute freqdomain_cpus for acpi-freq driver Date: Wed, 26 Jun 2013 10:41:44 +0800 Message-ID: <51CA54E8.6070805@intel.com> References: <1372126006-4950-1-git-send-email-tianyu.lan@intel.com> <51C95282.3040305@intel.com> <4163057.9R6dzfOLVQ@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <4163057.9R6dzfOLVQ@vostro.rjw.lan> Sender: cpufreq-owner@vger.kernel.org To: "Rafael J. Wysocki" , Viresh Kumar Cc: lenb@kernel.org, jean-philippe.halimi@exascale-computing.eu, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, cpufreq@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 2013=E5=B9=B406=E6=9C=8826=E6=97=A5 07:03, Rafael J. Wysocki wrote: > On Tuesday, June 25, 2013 09:01:03 PM Viresh Kumar wrote: >> On 25 June 2013 13:49, Lan Tianyu wrote: >>> Ok. From my opinion, the new attribute is an ABI and it's better to= add >>> descriptor under Document directory. The user can be easy to find h= ow to >>> use it. >> >> Hmm.. So maybe acpi-cpufreq file would be a good starting point. The= n >> it can have more details about the driver in future. >> >>> Please see the commit which add the code. Maybe, we should overwrit= e >>> shared_cpu_map by sibling_cpus for this case? >> >> Not sure if changing shared_cpu_map has any other implications or no= t. >=20 > Well, I wouldn't change it, then. Ok. How about add new field "cpufreqdomain_cpus" in the struct acpi_cpufreq_data and expose its value for new attribute. For normal case, copy the shared_cpu_map to it for normal case. For AMD case, copy sibling_cpus to it. Another choice, just keeping what my patch has done. Wait for the ne= w request since current patch can satisfy reporter and it's not clear whether the patch is enough for AMD platform.(At last from my view). >=20 > Thanks, > Rafael >=20 >=20 --=20 Best regards Tianyu Lan