From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Tony Luck <tony.luck@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>,
ananth@in.ibm.com, masbock@linux.vnet.ibm.com,
lcm@linux.vnet.ibm.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
Huang Ying <ying.huang@intel.com>
Subject: Re: [PATCH v2 2/2] mce: acpi/apei: Add a boot option to disable ff mode for corrected errors
Date: Mon, 01 Jul 2013 20:37:43 +0530 [thread overview]
Message-ID: <51D19B3F.3060405@linux.vnet.ibm.com> (raw)
In-Reply-To: <CA+8MBbJNY7G+q=kBgOA=+jVtugrfteoMvwLtfwvCno5xg+dm-Q@mail.gmail.com>
On 06/28/2013 11:01 PM, Tony Luck wrote:
>> + if (sec_sev == GHES_SEV_CORRECTED &&
>> + (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED) &&
>> + (mem_err->validation_bits & CPER_MEM_VALID_PHYSICAL_ADDRESS)) {
>> + unsigned long pfn;
>> + pfn = mem_err->physical_addr >> PAGE_SHIFT;
>
> As Reagan said "Trust ... but verify" ... we should make sure BIOS
> gave us a good pfn
> if (pfn_valid(pfn))
> soft_memory_failure_queue(pfn, 0, 0);
> else
> printk( ...something about
> BIOS giving us bad pfn = %lu\n", pfn);
Ah, nice catch - I thought soft_offline_page() takes care of this, but
it sure is good to point a finger at the firmware.
Thanks!
- Naveen
>> + }
>
next prev parent reply other threads:[~2013-07-01 15:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 17:57 [PATCH v2 1/2] mce: acpi/apei: Honour Firmware First for MCA banks listed in APEI HEST CMC Naveen N. Rao
2013-06-19 17:57 ` [PATCH v2 2/2] mce: acpi/apei: Add a boot option to disable ff mode for corrected errors Naveen N. Rao
2013-06-19 18:04 ` Borislav Petkov
2013-06-19 18:17 ` Naveen N. Rao
2013-06-19 18:19 ` Luck, Tony
2013-06-19 18:36 ` Borislav Petkov
2013-06-19 19:05 ` Luck, Tony
2013-06-19 20:14 ` Borislav Petkov
2013-06-19 20:33 ` Luck, Tony
2013-06-19 21:07 ` Borislav Petkov
2013-06-19 21:28 ` Luck, Tony
2013-06-19 21:41 ` Borislav Petkov
2013-06-19 22:08 ` Luck, Tony
2013-06-20 5:35 ` Borislav Petkov
2013-06-20 21:21 ` Naveen N. Rao
2013-06-20 22:11 ` Luck, Tony
2013-06-21 7:27 ` Borislav Petkov
2013-06-21 16:43 ` Naveen N. Rao
2013-06-28 12:04 ` Naveen N. Rao
2013-06-28 17:31 ` Tony Luck
2013-07-01 15:07 ` Naveen N. Rao [this message]
2013-07-01 15:38 ` Borislav Petkov
2013-07-01 15:41 ` Naveen N. Rao
2013-06-20 7:48 ` Borislav Petkov
2013-06-20 19:02 ` Naveen N. Rao
2013-06-20 7:39 ` [PATCH v2 1/2] mce: acpi/apei: Honour Firmware First for MCA banks listed in APEI HEST CMC Borislav Petkov
2013-06-20 19:08 ` Naveen N. Rao
2013-06-20 19:29 ` Borislav Petkov
2013-06-20 20:14 ` Naveen N. Rao
2013-06-20 20:57 ` Borislav Petkov
2013-06-20 21:22 ` Naveen N. Rao
2013-06-21 7:34 ` Borislav Petkov
2013-06-21 7:46 ` Naveen N. Rao
2013-06-21 8:36 ` Borislav Petkov
2013-06-21 9:32 ` Naveen N. Rao
2013-06-21 14:08 ` Borislav Petkov
2013-06-21 16:47 ` Tony Luck
2013-06-21 17:40 ` Borislav Petkov
2013-06-25 17:46 ` Naveen N. Rao
2013-06-25 17:53 ` Borislav Petkov
2013-06-25 17:55 ` Luck, Tony
2013-06-25 18:28 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51D19B3F.3060405@linux.vnet.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=bp@alien8.de \
--cc=lcm@linux.vnet.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masbock@linux.vnet.ibm.com \
--cc=tony.luck@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).